Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The zQ3sh prefix of most keys makes the key labels displayed next to user names less useful #102

Open
zah opened this issue Dec 3, 2022 · 3 comments

Comments

@zah
Copy link

zah commented Dec 3, 2022

The Status app displays a short version of the key of each user next to their display name, but most keys start with the zQ3sh prefix (courtesy of the used multiformats standard), which leaves just 3 characters at the end of the key to distinguish each user.

Consider using a different way to display the shortened key or dropping this feature altogether as it has limited usefulness (it's probably quite easy to forge a key matching the 3-character suffix of another user that you are trying to impersonate).

@0x-r4bbit
Copy link
Member

@iurimatias I think you've brought this up before.
@zah we were considering dropping the multiformat prefix. Downside then is that you give away more of the actual bytes as less of the key data is then elided. Maybe that's not that big of a deal. Something to revisit for sure /cc @John-44

@iurimatias iurimatias transferred this issue from status-im/status-desktop Apr 25, 2023
@John-44
Copy link
Collaborator

John-44 commented Apr 25, 2023

@zah @0x-r4bbit @iurimatias the way we deal with this issue in the new Status designs is that we are supposed to display only the first 3 characters of the user's chat key (which are always the same), and then after the ellipsis we display the last 6 characters of the compressed key (which are always different). See example below from the current mobile designs:

2023-04-25 16_30_57-Messages for Mobile – Figma

Although this change is in all the new mobile designs, and the Status Desktop 2.0 designs, it hasn't been brought back into the legacy Status Desktop 1.0 designs. But I don't see any reason why we shouldn't implement this change in Status Desktop right now.

@arnetheduck
Copy link
Member

I've highlighted a similar issue with #93 where the key formatting is not interoperable with virtually the entire rest of the ethereum ecosystem - using a non-standard address like this is confusing, even if there are some limited benefits for the QR code (which indeed could use an alternative encoding)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants