Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility to devel / Nim 2 + ORC #325

Closed
TechThupport opened this issue Oct 23, 2022 · 2 comments
Closed

Compatibility to devel / Nim 2 + ORC #325

TechThupport opened this issue Oct 23, 2022 · 2 comments

Comments

@TechThupport
Copy link

Not really an issue but more of a clarification if chronos will be ported to be compatible with Nim devel branch or Nim 2. According to Araq the release should be happening soon or within 2022.

@Menduist
Copy link
Collaborator

Menduist commented Oct 23, 2022

The CI is ran with multiple Nim versions, including devel: https://github.com/status-im/nim-chronos/blob/master/.github/workflows/ci.yml#L25
It's impossible to guarantee devel compatibility at all time since they may break anything at anytime, but we try our best to be compatible with devel. I also think that chronos is part of the important_packages of the Nim CI

This sould be clarified in the README, indeed

@TechThupport
Copy link
Author

TechThupport commented Oct 30, 2022

I'm mainly getting the below error when trying to compile for windows with --mm:orc

Not sure if this is only an issue for me or what. Chronos 3.0.11 installed:

chronos/asyncmacro2.nim(126, 31) Error: 'handleRequest' is not GC-safe as it calls 'selectExt'

Found out this is only a problem when using the nim-websock library

websock-0.1.0/websock/websock.nim(258, 5) template/generic instantiation of `async` from here

It is fixed now with latest commit to websock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants