CI with nimble #309
Closed
CI with nimble #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables faster development cycles at the expense of code coverage accuracy.
To get a reasonable test execution time.
To prevent subsequent `make` command to build a different version of Nim.
So that nimbus-build-system doesn't have to do it afterwards.
Will automatically update caches when a new minor version of Nim is released. See also: https://github.com/actions/cache/blob/main/workarounds.md#update-a-cache
Requires an update to latest nim-nat-traversal
To get a reasonable test execution time.
To get a reasonable test execution time.
To get a reasonable test execution time.
Start Ethereum node *after* the unit tests are run.
Allows for faster feedback loops; a next attempt to run the CI will start sooner.
markspanbroek
force-pushed
the
ci-with-nimble
branch
from
0b2d7e2
to
fa20567
Compare
markspanbroek
force-pushed
the
fix-nimble
branch
from
3c32da5
to
c65a252
Compare
|
Incredibly I think this may start making sense to consider again once nimble integrates the SAT solver that's been in the works for Atlas, assuming package maintainers also start issuing proper releases. But I'd close this PR for now as I don't think it's anything we'll be doing short-term, what do you think @markspanbroek? |
|
Yeah, let's close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs continuous integration with nimble instead of nimbus build system. Both simplifies the CI configuration and speeds up the build, but it's probably not wise to merge this until a version of Nimble that supports lock files has been released with Nim.
Depends on #305.