Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom hash function for eth1 ecdh #222

Closed
arnetheduck opened this issue Apr 15, 2020 · 1 comment · Fixed by status-im/nim-secp256k1#48 or #600
Closed

Use custom hash function for eth1 ecdh #222

arnetheduck opened this issue Apr 15, 2020 · 1 comment · Fixed by status-im/nim-secp256k1#48 or #600

Comments

@arnetheduck
Copy link
Member

We currently extend upstream libsecp256k1 to add a secp256k1_ecdh_raw function - since this was implemented, upstream has added the ability do do custom hash functions that could be used to implement this ethereum-specific way of deriving keys - as such, we can stop patching upstream and move the logic into nim-eth.

Upstream discussion:
bitcoin-core/secp256k1#352

Implementation blueprint:
https://github.com/bitcoin-core/secp256k1/blob/master/src/modules/ecdh/tests_impl.h#L18-L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants