Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWANT replies can be bigger than the pubsub message limit #887

Closed
alrevuelta opened this issue May 9, 2023 · 1 comment · Fixed by #944
Closed

IWANT replies can be bigger than the pubsub message limit #887

alrevuelta opened this issue May 9, 2023 · 1 comment · Fixed by #944

Comments

@alrevuelta
Copy link
Contributor

I'm a bit confused by this log. It says that msgSize=4950305 (5MB) but I'm sure that all the messages im publishing are exactly 0.9 MB. So is this log related to gossipsub? or some other type of "message" (perhaps lower level?)

trying to send a too big for pubsub        topics="libp2p pubsubpeer" tid=1 file=pubsubpeer.nim:248 maxSize=1048576 msgSize=4950305
@Menduist
Copy link
Contributor

Menduist commented May 9, 2023 •
edited

This is probably caused by an IWANT reply which may bundle multiple messages
Need to split messages when we are oversized

@Menduist Menduist changed the title Wrong log "trying to send a too big for pubsub " IWANT replies can be bigger than the pubsub message limit May 9, 2023
@alrevuelta alrevuelta mentioned this issue May 9, 2023
Open
3 tasks
@diegomrsantos diegomrsantos mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split msgs in iwant response if bigger than limit vacp2p/nim-libp2p
2 participants
@alrevuelta @Menduist