Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve CI workflow stability #1004

Closed
wants to merge 2 commits into from

Conversation

romanzac
Copy link
Collaborator

I would like to receive team's feedback on several changes I've prepared to address CI workflow stability.

This PR introduces possibility to preset Nimble version during Nim 1.x build. Benefits of such change are:

  • Possible to have any version of Nimble even for Nim v1.x.
  • Get native Nimble lock functionality for Nim v1.x.
  • Keep Nimble versions same across different Nim versions -> simplified troubleshooting
  • Get Nimble issues fixed faster - the newest versions usually get preference

Caching is disabled for CI workflow temporarily. Once we have more stability, we can start tuning for speed.

@romanzac romanzac marked this pull request as ready for review December 14, 2023 15:40
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1004 (c406613) into unstable (3011ba4) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #1004      +/-   ##
============================================
- Coverage     83.16%   83.12%   -0.04%     
============================================
  Files            91       91              
  Lines         15327    15327              
============================================
- Hits          12746    12741       -5     
- Misses         2581     2586       +5     

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants