docs: add comments and improve yamux readability #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## unstable #1006 +/- ##
============================================
+ Coverage 83.14% 83.16% +0.01%
============================================
Files 91 91
Lines 15335 15340 +5
============================================
+ Hits 12750 12757 +7
+ Misses 2585 2583 -2
|
| if channel.lengthSendQueueWithLimit() > channel.maxSendQueueSize: | ||
| debug "channel send queue too big, resetting", maxSendQueueSize=channel.maxSendQueueSize, | ||
| trace "channel send queue too big, resetting", maxSendQueueSize=channel.maxSendQueueSize, |
There was a problem hiding this comment.
I would leave this as debug
diegomrsantos
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a clear lack of comments on Yamux. This PR should solve this problem.