improvement: enhanced checkExpiring macro with custom timeout #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1023 +/- ##
=========================================
Coverage 83.18% 83.18%
=========================================
Files 91 91
Lines 15349 15351 +2
=========================================
+ Hits 12768 12770 +2
Misses 2581 2581 |
diegomrsantos
changed the title
diegomrsantos
force-pushed
the
checkExpiring
branch
from
dd7155a
to
cf76407
Compare
lchenut
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Customizable Timeout: The macro now accepts a timeout parameter, allowing users to specify a custom duration for the condition check. This enhances flexibility, especially in scenarios where the default 10-second timeout might not be suitable.
Improved Condition Handling: The macro has been upgraded to support multiple conditions, each on a separate line. It behaves like the
checkmacro and provides detailed diagnostics by indicating which specific condition was not satisfied and why.