Send priority with queue fix #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1051 +/- ##
============================================
+ Coverage 82.77% 82.80% +0.02%
============================================
Files 91 91
Lines 15666 15749 +83
============================================
+ Hits 12968 13041 +73
- Misses 2698 2708 +10
|
| discard p.rpcmessagequeue.sendPriorityQueue.popLast() | ||
|
|
||
| when defined(libp2p_expensive_metrics): | ||
| libp2p_gossipsub_priority_queue_size.set(labelValues = [$p.peerId]) |
There was a problem hiding this comment.
This doesnt compile when the flag is enabled
There was a problem hiding this comment.
26a37e3 - might be a good idea to enable these flags in CI builds
diegomrsantos
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reapplies #1015 and is a smaller version of #1028 that focuses on clearing the priority queue at both ends since the completion order of send futures may be reversed.
The PR also introduces a workaround for redundant msg copies when sending encoded messages and ensures that
sendMsgalways returns a future that can be used for backpressure.It creates two new metrics
libp2p_gossipsub_priority_queue_sizeandlibp2p_gossipsub_non_priority_queue_sizethat can be enabled with thepubsubpeer_queue_metricsflag. It should be used only locally as it is by peer and create a large amount of data.