GossipSub Rate Limit #920
Merged
GossipSub Rate Limit #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
traffic-scoring
branch
4 times, most recently
from
8a02654
to
0096fbe
Compare
Menduist
reviewed
Jun 23, 2023
Codecov Report
@@ Coverage Diff @@
## unstable #920 +/- ##
============================================
- Coverage 83.10% 83.10% -0.01%
============================================
Files 91 91
Lines 15235 15288 +53
============================================
+ Hits 12661 12705 +44
- Misses 2574 2583 +9 |
Menduist
reviewed
Jun 23, 2023
diegomrsantos
force-pushed
the
traffic-scoring
branch
5 times, most recently
from
0c948da
to
f2ff1e3
Compare
diegomrsantos
force-pushed
the
traffic-scoring
branch
from
c8c851a
to
6ffaf32
Compare
Menduist
reviewed
Jul 25, 2023
Menduist
reviewed
Jul 25, 2023
Menduist
reviewed
Jul 25, 2023
Menduist
reviewed
Jul 25, 2023
diegomrsantos
force-pushed
the
traffic-scoring
branch
2 times, most recently
from
c3f9bec
to
397e2c3
Compare
diegomrsantos
force-pushed
the
traffic-scoring
branch
from
e03756a
to
1dd3a0d
Compare
diegomrsantos
force-pushed
the
traffic-scoring
branch
2 times, most recently
from
6842b9a
to
7ea1c8b
Compare
diegomrsantos
force-pushed
the
traffic-scoring
branch
from
b4d8d88
to
03f67f2
Compare
lchenut
reviewed
Aug 16, 2023
lchenut
reviewed
Aug 16, 2023
lchenut
reviewed
Aug 16, 2023
lchenut
reviewed
Aug 16, 2023
diegomrsantos
force-pushed
the
traffic-scoring
branch
from
24588b0
to
c7884d5
Compare
Menduist
reviewed
Sep 12, 2023
| @@ -78,7 +79,8 @@ proc init*(_: type[GossipSubParams]): GossipSubParams = | |||
| disconnectBadPeers: false, | |||
| enablePX: false, | |||
| bandwidthEstimatebps: 100_000_000, # 100 Mbps or 12.5 MBps | |||
| iwantTimeout: 3 * GossipSubHeartbeatInterval | |||
| iwantTimeout: 3 * GossipSubHeartbeatInterval, | |||
| overheadRateLimitConfOpt: Opt.none(tuple[bytes: int, interval: Duration]) | |||
There was a problem hiding this comment.
Suggested change
| overheadRateLimitConfOpt: Opt.none(tuple[bytes: int, interval: Duration]) | |
| overheadRateLimit: Opt.none(tuple[bytes: int, interval: Duration]) |
There was a problem hiding this comment.
This is different from the actual rate limit, it is a config. Adding the Opt makes using withValue cleaner.
There was a problem hiding this comment.
Everything in that structure is a config, it's even named GossipSubParams
And since when do we put the type of a variable in its name?
Menduist
reviewed
Sep 20, 2023
| @@ -116,3 +116,32 @@ func shortLog*(m: RPCMsg): auto = | |||
| messages: mapIt(m.messages, it.shortLog), | |||
| control: m.control.get(ControlMessage()).shortLog | |||
| ) | |||
|
|
|||
| proc byteSize*(msg: Message): int = | |||
There was a problem hiding this comment.
Same issue as #944 (comment), but I guess we can unify that after merging this PR
Menduist
approved these changes
Sep 20, 2023
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea here is to eventually disconnect peers that send us too much useless data in a short amount of time (potentially DoSing us). The definition of useless we chose depends if the singing mode is enabled or not. If so, it is everything but the messages themselves. Otherwise, it is everything but the data and the topicIDs inside the message. For now, we just log and measure the number of times peers are above their rate limit - the max amount of useless data they can send us for a given interval.