Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit fixes #965

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Rate limit fixes #965

merged 3 commits into from
Nov 9, 2023

Conversation

diegomrsantos
Copy link
Collaborator

@diegomrsantos diegomrsantos commented Oct 13, 2023

  • "e2e - GossipSub should not rate limit decodable messages below the size allowed" test was flaky because sometimes the test would behave differently from what was expected due to failed signature verification. Always disabling the signature hopefully will fix it.
  • Another test was added for the case when the rate limit happens due to invalid domain messages.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #965 (3a46834) into unstable (60f9536) will increase coverage by 0.07%.
Report is 1 commits behind head on unstable.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #965      +/-   ##
============================================
+ Coverage     83.20%   83.28%   +0.07%     
============================================
  Files            91       91              
  Lines         15308    15312       +4     
============================================
+ Hits          12737    12752      +15     
+ Misses         2571     2560      -11     
Files Coverage Δ
libp2p/protocols/pubsub/gossipsub/scoring.nim 91.66% <100.00%> (+1.53%) ⬆️
libp2p/protocols/pubsub/gossipsub.nim 88.08% <33.33%> (+0.20%) ⬆️

... and 7 files with indirect coverage changes

lchenut
lchenut previously approved these changes Oct 17, 2023
@diegomrsantos diegomrsantos merged commit ebef85c into unstable Nov 9, 2023
9 of 10 checks passed
@diegomrsantos diegomrsantos deleted the rate-limit-fixes branch November 9, 2023 13:20
romanzac pushed a commit that referenced this pull request Nov 30, 2023
dryajov pushed a commit that referenced this pull request Dec 4, 2023
romanzac pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants