Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move workflows for Nim Devel and legacy i386 from "Daily" #968

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

romanzac
Copy link
Collaborator

We have "unstable" as a default branch. Others may expect from it more stability than its name suggest. I propose to make "Daily" workflow more reliable by moving tests with Nim Devel to separate (experimental?) workflow.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #968 (6f81d74) into unstable (60f9536) will increase coverage by 0.03%.
Report is 13 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #968      +/-   ##
============================================
+ Coverage     83.20%   83.23%   +0.03%     
============================================
  Files            91       91              
  Lines         15308    15326      +18     
============================================
+ Hits          12737    12757      +20     
+ Misses         2571     2569       -2     

see 22 files with indirect coverage changes

@romanzac romanzac changed the title Test: Remove workflow for Nim Devel from "Daily" Test: Move workflows for Nim Devel and legacy i386 from "Daily" Nov 1, 2023
@arnetheduck
Copy link
Contributor

i386 is there to ensure that libp2p continues to work with 32-bit platforms in general (ie arm) - as of the last time someone looked into this, it was the least bad 32-bit option available in CI and it should be maintained as such or replaced by another 32-bit CI.

@romanzac
Copy link
Collaborator Author

romanzac commented Nov 1, 2023

i386 is there to ensure that libp2p continues to work with 32-bit platforms in general (ie arm) - as of the last time someone looked into this, it was the least bad 32-bit option available in CI and it should be maintained as such or replaced by another 32-bit CI.

@arnetheduck This PR will still keep running Daily for i386, just in specialized workflow for legacy platforms. If you could name at least one recent 32bit platform, which has some public adoption, we could definitely discuss to include it in main workflow and provide first grade support. You would probably agree we don't have unlimited resources to support all platforms equally. I would even add, being selective and timely on what we support to which extent could make or break usability of something so essential like p2p library.

@arnetheduck
Copy link
Contributor

arnetheduck commented Nov 1, 2023

If you could name at least one recent 32bit platform

raspberry pi, android, openwrt (ie most home wifi routers out there)

@romanzac
Copy link
Collaborator Author

romanzac commented Nov 1, 2023

If you could name at least one recent 32bit platform

raspberry pi, android, openwrt (ie most home wifi routers out there)

Let me discuss those internally within Status. Thanks.

@romanzac romanzac changed the title Test: Move workflows for Nim Devel and legacy i386 from "Daily" fix: move workflows for Nim Devel and legacy i386 from "Daily" Nov 3, 2023
Copy link
Collaborator

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good, just added two small comments

lchenut
lchenut previously approved these changes Nov 24, 2023
Copy link
Collaborator

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address my question.

diegomrsantos
diegomrsantos previously approved these changes Nov 27, 2023
@romanzac romanzac dismissed stale reviews from diegomrsantos and lchenut via 149c075 November 28, 2023 06:49
diegomrsantos
diegomrsantos previously approved these changes Nov 29, 2023
- remove workflow for Nim Devel from Daily
- rename workflow to Daily - Nim Devel
- refactor workflows to reduce duplicities
- ump outdated actions/checkout@v4, actions/setup-go@v4
- change deprecated option --gc -> --mm
- split out legacy platforms (i386)
- better WF names with emphasis on target, Nim Devel, Legacy Platforms
- new line added
@romanzac romanzac reopened this Nov 30, 2023
@romanzac romanzac merged commit 3230407 into unstable Dec 1, 2023
9 of 10 checks passed
@romanzac romanzac deleted the test/nim-devel-workflow branch December 1, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants