fix(identify): do not add p2p and relayed addrs to observed addr manager #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we use the ObservedAddrManager only to find our dialable external NAT address. Therefore, addresses like "...\p2p-circuit\p2p\..." and "\p2p\..." are not useful to us.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #990 +/- ##
============================================
+ Coverage 83.18% 83.20% +0.02%
============================================
Files 91 91
Lines 15327 15328 +1
============================================
+ Hits 12750 12754 +4
+ Misses 2577 2574 -3
|
lchenut
approved these changes
Nov 21, 2023
romanzac
pushed a commit
that referenced
this pull request
Nov 30, 2023
dryajov
pushed a commit
that referenced
this pull request
Dec 4, 2023
romanzac
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use the ObservedAddrManager only to find our dialable external NAT address. Therefore, addresses like "...\p2p-circuit\p2p..." and "\p2p..." are not useful to us.