uiux: allow for changing app's fontsize #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
reviewed
Oct 5, 2020
| anchors.top: themeSetting.bottom | ||
| anchors.topMargin: 20 | ||
| anchors.left: parent.left | ||
| anchors.leftMargin: 24 |
There was a problem hiding this comment.
Suggested change
| anchors.leftMargin: 24 | |
| anchors.leftMargin: Style.current.bigPadding |
| checked: Style.fontSizeSetting === AppearanceContainer.FontSize.Normal | ||
| Layout.alignment: Qt.AlignRight | ||
| ButtonGroup.group: fontSize | ||
| rightPadding: 15 |
There was a problem hiding this comment.
Suggested change
| rightPadding: 15 | |
| rightPadding: Style.current.padding |
| checked: Style.fontSizeSetting === AppearanceContainer.FontSize.Big | ||
| Layout.alignment: Qt.AlignRight | ||
| ButtonGroup.group: fontSize | ||
| rightPadding: 15 |
There was a problem hiding this comment.
Suggested change
| rightPadding: 15 | |
| rightPadding: Style.current.padding |
|
I recommend NOT merging this one because well... as I've said last week. This definitely needs much more thought. Changing font sizes also affects margins and heights of components and the over all look & feel. |
|
I just tested and apart from a few fields and popups in the Wallet, it looks very good to me. |
|
@PascalPrecht can we enable app scaling by Scaling Up (CMD+"+") and Scaling Down (CMD+"-")? I think this can save us some hours of work... |
|
Closing in favour of #1404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737