feat: add sticker loading UI #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #586 Previously, loading sticker packs and stickers would show a lot of blank and non-interactive content. Now, stickers and sticker packs have grey circles to indicate loading. Additionally, the sticker market button (+) shows a loading indicator until the sticker packs are loaded.
emizzle
requested review from
iurimatias,
michaelsbradleyjr,
0x-r4bbit,
richard-ramos and
jrainville
jrainville
approved these changes
Sep 18, 2020
| @@ -260,9 +268,17 @@ QtObject: | |||
| write = setActiveChannelByIndex | |||
| notify = activeChannelChanged | |||
|
|
|||
| proc getNumInstalledStickerPacks(self: ChatsView): QVariant {.slot.} = | |||
| newQVariant(self.status.stickers.installedStickerPacks.len) | |||
There was a problem hiding this comment.
You could just return this as an int no?
|
we shouldn't merge this PR for now due to GC error |
|
after a chat with @michaelsbradleyjr and @richard-ramos this is ok to merge |
emizzle
pushed a commit
that referenced
this pull request
Dec 14, 2020
The sticker loading UI was removed when the StatusChatInput and friends were added in. This PR re-adds the sticker loading UI introduced in PR# 955 (#955).
iurimatias
pushed a commit
that referenced
this pull request
Dec 18, 2020
The sticker loading UI was removed when the StatusChatInput and friends were added in. This PR re-adds the sticker loading UI introduced in PR# 955 (#955).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #586
Previously, loading sticker packs and stickers would show a lot of blank and non-interactive content.
Now, stickers and sticker packs have grey circles to indicate loading. Additionally, the sticker market button (+) shows a loading indicator until the sticker packs are loaded.
Note
If a recent sticker is clicked while the sticker packs are still loading, the app crashes due to some kind of conflict in threads. I spent some time trying to figure this out, but could not get anywhere. Maybe @richard-ramos has an idea?