Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waku Message support version 1 (v1 waku envelope data format) for encrypted payload #192

Closed
oskarth opened this issue Sep 30, 2020 · 2 comments
Assignees

Comments

@oskarth
Copy link
Contributor

oskarth commented Sep 30, 2020

Problem

Currently we don't support encrypted payload. This has been speced out in https://specs.vac.dev/specs/waku/v2/waku-message.html#version-1 Basically it amounts to re-using already implemented code in Waku v1.

Acceptance criteria

WakuMessage v1 with encrypted payloads is supported.

Notes

There are probably some gotchas here in terms of how code is structured for Waku v1. This issue can possibly be broken down further. @kdeme any thoughts?

The payload for v1 is defined in nim-eth: https://github.com/status-im/nim-eth/blob/master/eth/p2p/rlpx_protocols/whisper/whisper_types.nim#L45

For usage, see https://github.com/status-im/nim-waku/blob/master/waku/protocol/v1/waku_protocol.nim#L489


Another issue after this is ensuring compatibility with Waku v1, e.g. with bridging or some standalone tests. Though this should be fine, assuming same keys and types are used.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 26, 2020

Simplest start here is probably to make a standalone test here with version filed in that tests de/encrypt using existing code for Waku v1, just putting it in a WakuMessage.

@oskarth
Copy link
Contributor Author

oskarth commented Nov 10, 2020

I believe this was done in PR above.

@oskarth oskarth closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants