WakuNode init without WakuNodeConf #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarth
approved these changes
Sep 1, 2020
oskarth
pushed a commit
that referenced
this pull request
Sep 1, 2020
* WakuNode init without WakuNodeConf * WakuNode start without WakuNodeConf * setupNat adjustments for making common version * Move setupNat to common.nim to be used for v1 and v2
oskarth
added a commit
that referenced
this pull request
Sep 1, 2020
Regression introduced in #117 Happened due to example not being run on CI. - Add wakuexample to all target - Fix example2 to run - Basic formatting
oskarth
added a commit
that referenced
this pull request
Sep 1, 2020
Regression introduced in #117 Happened due to example not being run on CI. - Add wakuexample to all target - Fix example2 to run - Basic formatting
oskarth
added a commit
that referenced
this pull request
Sep 1, 2020
* Make basic Waku v2 examples run again Regression introduced in #117 Happened due to example not being run on CI. - Add wakuexample to all target - Fix example2 to run - Basic formatting * Update examples/v2/basic2.nim Co-authored-by: Kim De Mey <kim.demey@gmail.com> * Update examples/v2/basic2.nim * Update examples/v2/basic2.nim * Update examples/v2/basic2.nim Co-authored-by: Kim De Mey <kim.demey@gmail.com>
This was referenced Sep 10, 2020
staheri14
pushed a commit
that referenced
this pull request
Oct 29, 2020
* WakuNode init without WakuNodeConf * WakuNode start without WakuNodeConf * setupNat adjustments for making common version * Move setupNat to common.nim to be used for v1 and v2
staheri14
pushed a commit
that referenced
this pull request
Oct 29, 2020
* Make basic Waku v2 examples run again Regression introduced in #117 Happened due to example not being run on CI. - Add wakuexample to all target - Fix example2 to run - Basic formatting * Update examples/v2/basic2.nim Co-authored-by: Kim De Mey <kim.demey@gmail.com> * Update examples/v2/basic2.nim * Update examples/v2/basic2.nim * Update examples/v2/basic2.nim Co-authored-by: Kim De Mey <kim.demey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #116 and some
setupNatreuse between v1 and v2