Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace TaintedString type deprecated in nim 1.5 #1326

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 2, 2022

Fixes for the following warnings:

/Users/runner/work/nwaku/nwaku/apps/wakunode2/config.nim(439, 49) Warning: Deprecated since 1.5; TaintedString is deprecated [Deprecated]

@LNSD LNSD self-assigned this Nov 2, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 2, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d4a6bbe #1 2022-11-02 11:02:03 ~18 min linux 📦bin
✔️ d4a6bbe #1 2022-11-02 11:09:35 ~25 min macos 📦bin
✔️ 98b8136 #2 2022-11-02 11:20:29 ~17 min macos 📦bin
✔️ 98b8136 #2 2022-11-02 11:20:32 ~17 min linux 📦bin

Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@LNSD LNSD changed the title fix: replace TaintedString type deprecated in nim 1.6 fix: replace TaintedString type deprecated in nim 1.5 Nov 2, 2022
@LNSD LNSD merged commit 83ae698 into master Nov 2, 2022
@LNSD LNSD deleted the fix-remove-taintedstring branch November 2, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants