Skip to content
This repository has been archived by the owner on Apr 26, 2019. It is now read-only.

Bounties show zero balance when funded with a token different to SNT, ANT, SWT or ETH #467

Closed
0xjjpa opened this issue Jun 21, 2018 · 4 comments

Comments

@0xjjpa
Copy link

0xjjpa commented Jun 21, 2018

User Story

As an organisation, I want to fund bounty issues with my own ERC-20 tokens, so that my community gets rewarded by helping the product they support.

Description

Type: Bug

Summary: When funding a bounty with an ERC-20 token that isn't SWT, SNT, AWT or ETH, the contract isn't updated and the bounty shows up empty even though it has been funded with some tokens (e.g. MYB).

Expected behavior

The bounty shows up with the right amount of tokens deposited into the bounty. E.g:
image

Actual behavior

The bounty shows up zero balance, despite having some tokens being deposited into the bounty. E.g.:
image

image

(See bounty and contract address for detailed example).

Reproduction

  • Ensure you have added the status-open-bounty-app in your Github organisation, had been whitelisted by the Status team and the label bounty has been created, as well as the bot actually posting a contract after you label an issue

image

image

  • Fund the smart contract with any token different than SNT, ANT, SWT or ETH. In this case, we funded it with a MYB token.
  • See that the balance of the contract address does not change.
  • Get sad 😢

Additional Information

  • Ethereum wallet used: Metamask and Eidoo to fund the contract. At first it was used one that wasn't the one linked to the OpenStatus website (Eidoo wallet), but afterwards it was used the one linked without result.
  • Browser: Chrome
  • Operating System: OSX
@0xjjpa
Copy link
Author

0xjjpa commented Jun 21, 2018

@rcullito just mentioned in the chat channel the following likely reason why the token hasn't shown up:

image

Since the MYB token used did a token swap recently, the Parity Registry hasn't been updated.

@0xjjpa
Copy link
Author

0xjjpa commented Jun 28, 2018

@rcullito we finally managed to update the token registry with the new token. I think we now only need a cache refresh from your side 😊

@rcullito
Copy link
Contributor

great news @jjperezaguinaga ! taking a look into it now.

@rcullito
Copy link
Contributor

believe we can close this down for now as we seem to be over the hurdle with the MYB token. from our end, we'll try and make it more explicit in our documentation that new tokens require a ping in riot to let us know.

thanks for bringing up @jjperezaguinaga

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants