Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] WebEngine based js executor #450

Merged
merged 6 commits into from
Mar 25, 2020
Merged

[WIP] WebEngine based js executor #450

merged 6 commits into from
Mar 25, 2020

Conversation

vkjr
Copy link
Contributor

@vkjr vkjr commented Jan 29, 2019 •
edited
Loading

Done:

  • added js execution within QWebEnginePage
  • added example code that sets communication channel between js and cpp
  • added REACT_SYNC methods tag that can be used later to implement synchronous react-native calls

TODO:

  • make webengine linking optional to prevent failing on windows
  • add documentation on how to turn on internal js execution
  • enable logging again

@vkjr vkjr self-assigned this Jan 29, 2019
@vkjr vkjr force-pushed the feature/qjsengine_executor branch from d0f273f to 8d0e67a Compare February 1, 2019 18:26
@vkjr vkjr mentioned this pull request Jul 29, 2019
Open
@vkjr vkjr force-pushed the feature/qjsengine_executor branch from 8d0e67a to c5feb4b Compare October 9, 2019 07:24
@vkjr vkjr merged commit ee98cce into master Mar 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/qjsengine_executor branch March 25, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vkjr vkjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vkjr