Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to new API #11448

Closed
borismelnik opened this issue Jul 7, 2023 · 0 comments · Fixed by #11436
Closed

Update links to new API #11448

borismelnik opened this issue Jul 7, 2023 · 0 comments · Fixed by #11436
Assignees
@borismelnik
Labels
backend-team E:Desktop New Share URL Format Implementation of the new share URL link format and other deep link associated issues feature refactor
Milestone
0.14

Comments

@borismelnik
Copy link
Contributor

##Description

Dependent on #10851

Anywhere we still use direct uses of status.app/, replace by using the status-go function and its return.

##Acceptance Criteria

All the places where we show share URLs now show the new format:

  • community links in the community popup and invite popup
  • user links in the profile popup and settings
  • any other place where share links are used
@borismelnik borismelnik added this to the 0.14 milestone Jul 7, 2023
@borismelnik borismelnik self-assigned this Jul 7, 2023
@borismelnik borismelnik mentioned this issue Jul 7, 2023
Merged
4 tasks
@jrainville jrainville added C2 and removed C1 labels Jul 7, 2023
@lukaszso lukaszso linked a pull request Jul 11, 2023 that will close this issue
feat(new-links-format): Adds new links to UI #11436
Merged
4 tasks
@jrainville jrainville added the E:Desktop New Share URL Format Implementation of the new share URL link format and other deep link associated issues label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borismelnik borismelnik

Labels
backend-team E:Desktop New Share URL Format Implementation of the new share URL link format and other deep link associated issues feature refactor
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

feat(new-links-format): Adds new links to UI status-im/status-desktop
2 participants
@jrainville @borismelnik