Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profile Showcase] Custom positioning when reordering a filtered In showcase list #13682

Closed
Tracked by #12984
alexjba opened this issue Feb 22, 2024 · 1 comment · Fixed by #14486
Closed
Tracked by #12984

[Profile Showcase] Custom positioning when reordering a filtered In showcase list #13682

alexjba opened this issue Feb 22, 2024 · 1 comment · Fixed by #14486
Assignees
Labels
E:Desktop Profile Showcase Implementation of the Profile showcase feature ui-team
Milestone

Comments

@alexjba
Copy link
Contributor

alexjba commented Feb 22, 2024

Description

Design

The user is free to drag items into the showcase and re-order whilst in the search filtered state. 

We should follow Sheets / Excel logic for defining the relative position of moved items once the search filter is removed. 

In essence this logic is as follows:

Moving an item down the list while filter applied
When the filter is removed the item is left directly under under the item it was moved below while in the filtered state (we can only infer which of the visible list items they wish to move the list item below).

Moving an item up the list while filter applied
When the filter is removed the item is left directly above the item it is moved above while in the filtered state (we can only infer which of the visible list items they wish to move the list item above).

Note for development: Re-enable the DND

@alexjba alexjba added this to the 2.28.0 Beta milestone Feb 22, 2024
@alexjba alexjba added E:Desktop Profile Showcase Implementation of the Profile showcase feature labels Feb 22, 2024
@alexjba
Copy link
Contributor Author

alexjba commented Mar 4, 2024

Depends on #13508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Desktop Profile Showcase Implementation of the Profile showcase feature ui-team
Projects
Status: Done
3 participants