Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI - Swap] Create row radiobutton component with custom field #14784

Closed
Tracked by #14786
noeliaSD opened this issue May 15, 2024 · 0 comments · Fixed by #14887
Closed
Tracked by #14786

[UI - Swap] Create row radiobutton component with custom field #14784

noeliaSD opened this issue May 15, 2024 · 0 comments · Fixed by #14887
Assignees
@caybro
Labels
E:D Swap M1 Implement Swap operations feature ui-team
Milestone
2.30.0 Beta

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented May 15, 2024 •
edited

Design

Screenshot 2024-05-15 at 21 35 22

When Custom button is selected:
Screenshot 2024-05-15 at 21 35 37

  • Create row radiobutton component like the one defined in design
  • It shall contain custom set of buttons
  • It shall contain a Custom button that will be converted to an input field
  • Add the new component into a new storybook page
  • Create necessary qml tests to cover the component logic
This was referenced May 15, 2024
Open
Open
@noeliaSD noeliaSD added ui-team feature E:D Swap M1 Implement Swap operations labels May 15, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone May 15, 2024
caybro added a commit that referenced this issue May 23, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
6cf5c79 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
caybro added a commit that referenced this issue May 23, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
f2f1b1f 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
@caybro caybro linked a pull request May 23, 2024 that will close this issue
feat: [UI - Swap] Create row radiobutton component with custom field #14887
Merged
1 task
@caybro caybro mentioned this issue May 23, 2024
Merged
1 task
caybro added a commit that referenced this issue May 27, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
76d769d 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
caybro added a commit that referenced this issue May 27, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
0e21f59 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
caybro added a commit that referenced this issue May 27, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
d02d432 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
caybro added a commit that referenced this issue May 28, 2024
@caybro
feat: [UI - Swap] Create row radiobutton component with custom field
442111c 
- Create row radiobutton component like the one defined in design
- It shall contain custom set of buttons
- It shall contain a Custom button that will be converted to an input
field
- Add the new component into a new storybook page
- Create necessary qml tests to cover the component logic

Fixes #14784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
E:D Swap M1 Implement Swap operations feature ui-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

feat: [UI - Swap] Create row radiobutton component with custom field status-im/status-desktop
2 participants
@caybro @noeliaSD