You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are have jail cells which are forever alive and never disposed of during the life cycle of the status react app, which leads to specific issues like endless goroutines for the cells loop which handles task execution on the event loop for jail. This pose a problem and with @divan addition of cancelation of a cell's loop in #376, that leviates things abit, but does not total solve the issue, where if the Stop method is called, then a jail Cell instance becomes unsable.
Implementation
To resolve this issue, and allow react side to be able to start and stop user account related Jail Cells, we need to do the following:
Add Start method to all jail Cell to the already existing Stop method, which allows each Cell.loop instance to be stopped and started (instantiated/re-instantiated) as needed.
Expose StartCell(chatId) and StopCell(chatId) methods to react, to allow starting and stopping a Cell loop, either when the user switches account or does something that removes focus from the chat window of the respective account user.
Known steps towards feature implementation.
What needs further specifying and investigating.
Acceptance Criteria
Able to start and stop jail Cell without side effect of panic or task blow up
Closing as a duplicate of #260 with fixes in #376 and #382 (which doesn't expose jail cells to status-react but handles it internally upon SwitchAccount and Logout which is more correct).
Feel free to re-open if you think this issue is still needed.
Problem
We are have jail cells which are forever alive and never disposed of during the life cycle of the status react app, which leads to specific issues like endless goroutines for the cells
loop
which handles task execution on the event loop for jail. This pose a problem and with @divan addition of cancelation of a cell's loop in #376, that leviates things abit, but does not total solve the issue, where if theStop
method is called, then a jailCell
instance becomes unsable.Implementation
To resolve this issue, and allow react side to be able to start and stop user account related Jail
Cells
, we need to do the following:Start
method to all jailCell
to the already existingStop
method, which allows eachCell.loop
instance to be stopped and started (instantiated/re-instantiated) as needed.StartCell(chatId)
andStopCell(chatId)
methods to react, to allow starting and stopping aCell
loop, either when the user switches account or does something that removes focus from the chat window of the respective account user.Known steps towards feature implementation.
What needs further specifying and investigating.
Acceptance Criteria
Cell
without side effect of panic or task blow upFuture Steps
ClojureTeam
about new methods and have them utilized with account switching initially.The text was updated successfully, but these errors were encountered: