Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Start and Stop Methods to Jail #379

Closed
influx6 opened this issue Sep 29, 2017 · 1 comment
Closed

Add Start and Stop Methods to Jail #379

influx6 opened this issue Sep 29, 2017 · 1 comment

Comments

@influx6
Copy link
Contributor

influx6 commented Sep 29, 2017

Problem

We are have jail cells which are forever alive and never disposed of during the life cycle of the status react app, which leads to specific issues like endless goroutines for the cells loop which handles task execution on the event loop for jail. This pose a problem and with @divan addition of cancelation of a cell's loop in #376, that leviates things abit, but does not total solve the issue, where if the Stop method is called, then a jail Cell instance becomes unsable.

Implementation

To resolve this issue, and allow react side to be able to start and stop user account related Jail Cells, we need to do the following:

  • Add Start method to all jail Cell to the already existing Stop method, which allows each Cell.loop instance to be stopped and started (instantiated/re-instantiated) as needed.
  • Expose StartCell(chatId) and StopCell(chatId) methods to react, to allow starting and stopping a Cell loop, either when the user switches account or does something that removes focus from the chat window of the respective account user.

Known steps towards feature implementation.
What needs further specifying and investigating.

Acceptance Criteria

Future Steps

  • Inform ClojureTeam about new methods and have them utilized with account switching initially.
@tiabc
Copy link
Contributor

tiabc commented Oct 9, 2017

Closing as a duplicate of #260 with fixes in #376 and #382 (which doesn't expose jail cells to status-react but handles it internally upon SwitchAccount and Logout which is more correct).
Feel free to re-open if you think this issue is still needed.

@tiabc tiabc closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants