Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load images from an https server #12855

Closed
cammellos opened this issue Nov 29, 2021 · 1 comment · Fixed by #13039
Closed

Load images from an https server #12855

cammellos opened this issue Nov 29, 2021 · 1 comment · Fixed by #13039
Assignees
Labels
feature feature requests
Milestone

Comments

@cammellos
Copy link
Member

For performance reasons, we should load images from an https server run locally, instead of passing them through the bridge.

The issue is to automate the creation on certificates and making sure that they are trusted.

On IOS we can follow:

https://developer.apple.com/documentation/foundation/url_loading_system/handling_an_authentication_challenge/performing_manual_server_trust_authentication

while on Android we could use https://stackoverflow.com/a/57046889/13685841 , but it might require changing fast-image library.

The status-go PR is here status-im/status-go#2418 , I can update it to use SSL, @flexsurfer has done already some work here https://github.com/status-im/status-react/pull/12780/files (changing in the frontend are minimal, other than accepting the certificate).

@cammellos cammellos added the feature feature requests label Nov 29, 2021
@cammellos cammellos added this to the Release 1.19 milestone Dec 8, 2021
@Jonathansoufer Jonathansoufer self-assigned this Dec 9, 2021
@bitgamma
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants