New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve quo2 text component #13793
Comments
H @Parveshdhull I compared |
hi @yqrashawn, |
Closing for now due to inactivity |
reopening issue (#16981 (review)) |
related PR #13960, and related discussion #13960 (comment) |
add more info here merged PR #13960 fixed the formula in our code yet, quo2 text component is different from figma design A is figma design you can see B and C are identical, which means quo2 text implementation is the same as the Inter font recommended dynamic metrics implementation |
this might help https://www.figma.com/community/plugin/795733302011238428/Inter-Letter-Spacing |
1. letter-spacing
Letter spacing currently used by the component doesn't match with letter spacing for Figma design.
And looks like small changes in letter spacing are not affecting the text component.
Formula used by Figma for letter spacing: formula (ref)
Heading-1/Regular
2. Line Height:
The line height currently used by the component doesn't match with line height from the Figma design
Paragraph-2/Regular
[Original image]
The text was updated successfully, but these errors were encountered: