Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design notes: switch profiles #15789

Closed
5 of 11 tasks
churik opened this issue May 1, 2023 · 5 comments
Closed
5 of 11 tasks

Design notes: switch profiles #15789

churik opened this issue May 1, 2023 · 5 comments

Comments

@churik
Copy link
Member

churik commented May 1, 2023

Expected fixes

Profiles screen

  • Update background (full comment here)
  • Add drop shadow on profile cards (full comment here)
  • Check avatar font size #15793
  • Check background when scrolling profiles list(full comment here)
  • Add animation on transition between profiles (full comment here and video here)

Profile options

  • Check drawer background color (full comment here)
  • Update icon design (full comment here)
  • Check bottom padding (full comment here)

Delete drawer

  • Context tag should be blur (full comment here)
  • Button should be blur (full comment here)

Add new profile

  • Update icons (full comment here)
@churik churik added bug labels May 1, 2023
@cammellos
Copy link
Member

Update background (full comment here)
Add drop shadow on profile cards (full comment here)

@Parveshdhull I believe you did some investigation on those, and as I understand, they are technically quite complex, is that the case?

Thanks

@cammellos
Copy link
Member

Update icon design (full comment here)
Check bottom padding (full comment here)

These are small fixes

@cammellos
Copy link
Member

A lot of these issues have to do with blur, make sure you prioritize lower hanging fruits, if blur is causing issues

@Parveshdhull
Copy link
Member

Parveshdhull commented May 2, 2023

Update background (full comment here)
Add drop shadow on profile cards (full comment here)

@Parveshdhull I believe you did some investigation on those, and as I understand, they are technically quite complex, is that the case?

Yes,

  • update background - by default library doesn't support transparent blur type(ref), and for supporting that we are using patch provided in #513 pr, but this solution also creates a blue overlay side effect
  • drop shadow - Most of props related to drop shadow are only available for ios, so we are currently not able to show drop shadow in android. Also, for ios use of drop shadow is creating this weird square edges as mentioned in last section of issue 3 comment. (maybe because we use this with hole-view)

@cammellos cammellos added this to the 1.23.0 - Alpha milestone May 9, 2023
@J-Son89
Copy link
Member

J-Son89 commented May 18, 2023

@ajayesivan has handled the old/new icons issue here - #15937 so we can remove that as a requirement of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants