Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Implement Network Configuration #17840

Closed
J-Son89 opened this issue Nov 7, 2023 · 1 comment · Fixed by #17862
Closed

Wallet - Implement Network Configuration #17840

J-Son89 opened this issue Nov 7, 2023 · 1 comment · Fixed by #17862
Assignees
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes feature feature requests

Comments

@J-Son89
Copy link
Member

J-Son89 commented Nov 7, 2023

The Network Configuration page on the wallet designs has the UI implemented,
see: https://www.figma.com/file/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?type=design&node-id=900-230906&mode=design&t=vpLa1xN6Dn8Cb6nJ-4

now we need to hook this up to the db etc.

Each account will have it's own network configuration -

The approach decided on by the team for handling this data is to have a list of networks set by each wallet account

e.g

:wallet {
 :network-details ( collection of map of extensive network details)
 :accounts {
  "0x1..." {
    :network-preferences #(:ethereum :arbitrum)
    ...
    }
    "0x2..." {
    :network-preferences #(:ethereum)
    ...
    }
 }
}

so the sub for each account's network details will be something dependent on
:wallet/network-details and :wallet/account (or whatever its name is)

acceptance criteria:

  • create the required subs
  • create the required events
  • tests for the subs and events (make test)
  • this feature should work and the corresponding UI details should be relevant for this, i.e update uses of network-details sub where correct to do so
@J-Son89 J-Son89 added the feature feature requests label Nov 7, 2023
@J-Son89 J-Son89 self-assigned this Nov 7, 2023
@Rende11
Copy link
Collaborator

Rende11 commented Nov 7, 2023

I would like to implement it!

@J-Son89 J-Son89 assigned Rende11 and unassigned J-Son89 Nov 7, 2023
@churik churik added the E:Mobile Wallet MVP Design system components, initial research and page wireframes label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet MVP Design system components, initial research and page wireframes feature feature requests
Development

Successfully merging a pull request may close this issue.

3 participants