Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curated communities are not fetched #17852

Closed
pavloburykh opened this issue Nov 8, 2023 · 22 comments
Closed

Curated communities are not fetched #17852

pavloburykh opened this issue Nov 8, 2023 · 22 comments

Comments

@pavloburykh
Copy link
Contributor

Steps:

  1. Create/restore an account
  2. Open Discover communities screen
  3. See if Curated communities are fetched

Actual result: Curated communities are not fetched

Status-debug-logs (79).zip

telegram-cloud-document-2-5357306334016451381.mp4

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@churik
Copy link
Member

churik commented Nov 8, 2023

So on desktop:

I'm not sure we're aligned on mobile

@ajayesivan ajayesivan self-assigned this Nov 8, 2023
@ajayesivan
Copy link
Contributor

I checked the last desktop nightly I got from here: https://ci.status.im/job/status-desktop/job/nightly/

Mainnet:
Screenshot 2023-11-08 at 22 29 46

Testnet:
Screenshot 2023-11-08 at 22 28 07

@ajayesivan
Copy link
Contributor

status-go api we use to fetch communities is giving nothing.
API: CuratedCommunities
Response:

{:contractCommunities nil, :contractFeaturedCommunities nil, :communities {}, :unknownCommunities nil}

@ajayesivan
Copy link
Contributor

ajayesivan commented Nov 8, 2023

We are showing the loading screen when the curated communities list is empty:

[:<>
[rn/view {:margin-bottom 16} [quo/community-card-view-item {:loading? true}]]
[rn/view {:margin-bottom 16} [quo/community-card-view-item {:loading? true}]]
[quo/community-card-view-item {:loading? true}]])])

@ajayesivan
Copy link
Contributor

@ajayesivan
Copy link
Contributor

ajayesivan commented Nov 8, 2023

So on desktop:

I'm not sure we're aligned on mobile

This is what I see in the links you shared,
https://community-dapp-git-review-status-im-web.vercel.app/directory:
Screenshot 2023-11-08 at 23 12 57

https://curate.status.app/directory:
Screenshot 2023-11-08 at 23 13 03

@churik Is it expected to load the lists displayed in these links onto the discover screens?

@ajayesivan
Copy link
Contributor

The Mainnet Community Directory Curation is currently empty and we don't have an empty variant for the discover screen, which is why the loading screen is displayed in this scenario.

@ajayesivan
Copy link
Contributor

  • Even in testnet status-go thinks the app is running in mainnet, m.settings.GetTestNetworksEnabled() - returns false - when running with mobile.
  • When I forced the code to fetch testnet communities it return one community public key but status-go fails to fetch the corresponding community data.

I tried importing the community with the public key on desktop and it returning nothing, see the screenshot below
Screenshot 2023-11-10 at 16 01 38

@ajayesivan
Copy link
Contributor

I was looking at the wrong place 🥲. In order to get communities on the test network we need to switch to status.test fleet.

Status App -> Settings -> Advanced -> Fleet -> status.test

@ajayesivan
Copy link
Contributor

When we are on testnet & status.test fleet atm there is only one community in the curated communities list:

Screenshot 2023-11-10 at 16 35 32

@pavloburykh
Copy link
Contributor Author

Hey @ajayesivan

I have checked status.test on mobile and curated community still not fetched for me

photo_2023-11-10 13 27 28
photo_2023-11-10 13 27 31

@pavloburykh
Copy link
Contributor Author

pavloburykh commented Nov 10, 2023

So, as far as I understand, we are not able to fetch community on Mainnet as the The Mainnet Community Directory Curation is currently empty as you mentioned above.

At the same community is not fetched on testnet (on mobile) despite there is 1 community that should be fetched.

Could it be the reason that mobile is looking at the wrong endpoints?

@ajayesivan
Copy link
Contributor

@pavloburykh, on mobile there is some issue with testnet or test fleet. It definitely needs a fix, I will ping you once it's ready for testing.

I was adding all my findings here.

@pavloburykh
Copy link
Contributor Author

We can ask felicio to add some community to Mainnet Community Directory Curation and see if it will be fetched on mobile. But I have an assumption that it will not be fetched.

@pavloburykh
Copy link
Contributor Author

pavloburykh commented Nov 10, 2023

@pavloburykh, on mobile there is some issue with testnet or test fleet. It definitely needs a fix, I will ping you once it's ready for testing.

I was adding all my findings here.

got it. Thank you for your investigation @ajayesivan

@ilmotta
Copy link
Contributor

ilmotta commented Nov 16, 2023

@pavloburykh, should we move this issue to release 1.27?

@pavloburykh
Copy link
Contributor Author

@pavloburykh, should we move this issue to release 1.27?

Yes. I have moved it to 1.27. Thanks @ilmotta

This was referenced Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants