Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectibles not displayed after watch only account is added until relogin #18613

Open
Tracked by #18611
VolodLytvynenko opened this issue Jan 24, 2024 · 11 comments
Open
Tracked by #18611
Assignees
Labels
E:Mobile Bug MVP E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet E:Mobile Wallet February All issues for the wallet mobile team for the month of february E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet medium-priority

Comments

@VolodLytvynenko
Copy link
Contributor

VolodLytvynenko commented Jan 24, 2024

Steps:

  1. Add watch only account with collectibles
  2. Go to the 'collectibles' tab

Actual result:

The collectibles are not displayed until the user performs a re-login.

Expected result:

The collectibles should be immediately visible as soon as the watch only account is added

Logs:

Status-debug-logs (1).zip

Additional info:

Feel free to reach out to me directly if you need a user with collectibles. I will provide the seed phrase.

@VolodLytvynenko VolodLytvynenko added E:Mobile Bug MVP E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet labels Jan 24, 2024
@mmilad75 mmilad75 self-assigned this Jan 24, 2024
@VolodLytvynenko VolodLytvynenko added E:Mobile Wallet March All issues for the mobile wallet for the month of March E:Mobile Wallet February All issues for the wallet mobile team for the month of february and removed E:Mobile Wallet March All issues for the mobile wallet for the month of March labels Mar 14, 2024
@J-Son89
Copy link
Member

J-Son89 commented Apr 8, 2024

@mmilad75, @VolodLytvynenko what's the status on this issue? Is it still a problem?

cc @smohamedjavid as you looked into account recovery recently, perhaps a part of a larger issue? 🤔

@VolodLytvynenko
Copy link
Contributor Author

@mmilad75, @VolodLytvynenko what's the status on this issue? Is it still a problem?

cc @smohamedjavid as you looked into account recovery recently, perhaps a part of a larger issue? 🤔

Yes @J-Son89 the problem still exists

@smohamedjavid
Copy link
Member

@VolodLytvynenko - Quick confirmation: The collectibles (which are not fetched) are from the additional accounts which are not recovered, right?

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented Apr 8, 2024

@VolodLytvynenko - Quick confirmation: The collectibles (which are not fetched) are from the additional accounts which are not recovered, right?

Hey @smohamedjavid
Collectibles are not fetched until the account is relogin in such cases:

  • When an account is recovered
  • When new account with collectibles is added (example: add this 0x8d2413447ff297d30bdc475f6d5cb00254685aae account as watch only)

@mmilad75
Copy link
Contributor

When an account is recovered (i.e. using recovery phrase), this is the list of accounts that are returned from back end which is only one account address:

Screenshot 2024-04-10 at 15 35 12

But when the same account is logged in, all of the accounts are returned:

Screenshot 2024-04-10 at 15 32 35

This seems to be a backend issue.

There is also one more issue when adding a new account for the first time as watch-only account:

Screenshot 2024-04-17 at 12 52 36

This is the log of calling backend using wallet_getOwnedCollectiblesAsync method. The following image is the response of the call:

Screenshot 2024-04-17 at 12 58 50

Where the [] is the collectibles, 0x8d2413447f297d30bdc475f6d5cb00254685aae is the address of the account, and false is the value of hasMore property. As it can be seen, there is no collectible returned from backend.

Now, after removing the account as watch-only, and the re-add it, the following will happen:

Screenshot 2024-04-17 at 12 54 14

As it can be seen, the same params are passed to the backend. But we are getting different response:

Screenshot 2024-04-17 at 12 55 30

As you can see here, the list of collectibles are returned, and the value of hasMore is also true here.

@VolodLytvynenko VolodLytvynenko added medium-priority E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet E:Mobile Wallet MVP Design system components, initial research and page wireframes labels Apr 26, 2024
@smohamedjavid
Copy link
Member

Collectibles are not fetched until the account is relogin in such cases:

  • When an account is recovered
  • When new account with collectibles is added (example: add this 0x8d2413447ff297d30bdc475f6d5cb00254685aae account as watch only)

@VolodLytvynenko - Can you check in the Desktop app? Try to recover a profile with multiple accounts (with collectibles in it). I believe this issue exists in Desktop as well.

When an account is recovered (i.e. using recovery phrase), this is the list of accounts that are returned from back end which is only one account address: But when the same account is logged in, all of the accounts are returned:

@mmilad75 - I fixed it in my PR: #20160

@VolodLytvynenko
Copy link
Contributor Author

@VolodLytvynenko - Can you check in the Desktop app? Try to recover a profile with multiple accounts (with collectibles in it). I believe this issue exists in Desktop as well.

hi @smohamedjavid On the desktop, the collectibles are shown after the account is recovered, but they are not shown for watch-only accounts even after relogin

@mmilad75
Copy link
Contributor

@VolodLytvynenko - Can you check in the Desktop app? Try to recover a profile with multiple accounts (with collectibles in it). I believe this issue exists in Desktop as well.

hi @smohamedjavid On the desktop, the collectibles are shown after the account is recovered, but they are not shown for watch-only accounts even after relogin

I faced the same thing. I tested with build 2.29.0-rc.4

@VolodLytvynenko VolodLytvynenko changed the title Collectibles not displayed after account recovery Collectibles not displayed after account recovery and after watch only account is added until relogin May 29, 2024
@smohamedjavid
Copy link
Member

@VolodLytvynenko - Can you help us confirm whether the issue is reproducible on your end in Desktop?

@VolodLytvynenko
Copy link
Contributor Author

@VolodLytvynenko - Can you help us confirm whether the issue is reproducible on your end in Desktop?

@smohamedjavid Yes. Will provide feedback soon

@VolodLytvynenko
Copy link
Contributor Author

VolodLytvynenko commented Jun 3, 2024

@VolodLytvynenko - Can you help us confirm whether the issue is reproducible on your end in Desktop?

@smohamedjavid On desktop, collectibles are shown immediately after the account is recovered. (on mobile they shown after relogin only)
However, for watch-only accounts, collectibles are not shown at all, even after re-login. (on mobile they shown after relogin)

logs.txt

@VolodLytvynenko VolodLytvynenko changed the title Collectibles not displayed after account recovery and after watch only account is added until relogin Collectibles not displayed after watch only account is added until relogin Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Bug MVP E:Mobile Wallet Collectibles Page MVP all issues for the collectibles page of the wallet E:Mobile Wallet February All issues for the wallet mobile team for the month of february E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet medium-priority
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants