Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display missing key pairs in wallet settings #20033

Closed
seanstrom opened this issue May 15, 2024 · 2 comments · Fixed by #20094
Closed

Display missing key pairs in wallet settings #20033

seanstrom opened this issue May 15, 2024 · 2 comments · Fixed by #20094
Assignees
Labels
E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team
Milestone

Comments

@seanstrom
Copy link
Member

Feature Issue

User Story

As a user,
I want to be able to see any of my missing (not imported) key pairs and accounts inside the wallet settings.

Description

Implement the initial UI for displaying the missing (not imported) or un-operable key pairs and accounts.

Designs

Figma flow: the Figma designs

Notes

  • The designs for importing missing key pairs include an "import" button. This feature is not in scope for this issue and will be tracked in a separate issue.
  • The designs for importing missing key pairs include an action menu for each missing key pair. This feature is partially in scope because we already support renaming and removing key pairs. The other features related to importing the key pair will be tracked in a separate issue.

Acceptance Criteria

Screen Description
Wallet Settings Users can choose to view the key pairs and accounts settings (inside wallet settings) by pressing on the "Key pairs and accounts" menu button.
Missing Key Pairs and Accounts Users should be able to see any missing key pairs and accounts. Missing key pairs and accounts would exist on other devices but not on the current device.
Missing Key Pairs and Accounts Action Menu Users should be able to open the action menu for a missing key pair.
@seanstrom seanstrom added E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. labels May 15, 2024
@seanstrom seanstrom self-assigned this May 15, 2024
@seanstrom seanstrom removed their assignment May 16, 2024
@seanstrom
Copy link
Member Author

Hey @smohamedjavid 👋
I have a question about how we could potentially detect which key pairs are not imported.

Should we check all the accounts for which ones are not operable, and then find their related key-pair and consider that as technically a "missing" key-pair?

@smohamedjavid
Copy link
Member

Yes, @seanstrom - In other words

if any of the accounts in a key pair is NON OPERABLE 
    The whole key pair will be NON OPERABLE.

if any of the accounts in a key pair is PARTIALLY OPERABLE 
    The whole key pair will be PARTIALLY OPERABLE.

else key pair is FULLY OPERABLE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Wallet Settings - Key Pairs and Accounts The epic for implementing the key-pairs and accounts settings for the mobile wallet settings. E:Mobile Wallet Settings All issues for the mobile wallet settings T:Mobile Wallet Settings Mobile Wallet Settings Team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants