Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wallet Connect structure #20040

Closed
clauxx opened this issue May 15, 2024 · 0 comments · Fixed by #20042
Closed

Fix Wallet Connect structure #20040

clauxx opened this issue May 15, 2024 · 0 comments · Fixed by #20042
Assignees
@clauxx
Labels
dapp-interactions-team E:Mobile MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs
Milestone
2.30.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented May 15, 2024

Problem

After the feedback received from @J-Son89, I adjusted the ns structure, moved constants to the appropriate ns and removed the utils ns. Along the way, found an unexpected bug in the re-frame effects usage.
@clauxx clauxx self-assigned this May 15, 2024
@clauxx clauxx added the E:Mobile MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs label May 15, 2024
@clauxx clauxx mentioned this issue May 15, 2024
Merged
@clauxx clauxx added this to the 2.30.0 Beta milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clauxx clauxx

Labels
dapp-interactions-team E:Mobile MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

Fix Wallet Connect structure status-im/status-mobile
1 participant
@clauxx