Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet: Calculate Max fees on transaction confirmation page #18408

Closed
J-Son89 opened this issue Jan 5, 2024 · 0 comments · Fixed by #20133
Closed

Wallet: Calculate Max fees on transaction confirmation page #18408

J-Son89 opened this issue Jan 5, 2024 · 0 comments · Fixed by #20133
Assignees
@briansztamfater
Labels
E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet feature feature requests high-priority

Comments

@J-Son89
Copy link
Member

J-Son89 commented Jan 5, 2024

In the transaction confirmation page of the wallet flows, the max fees data needs to be correctly calculated.

Please align with Desktop team how this is to be done properly using the data from the routes. Particularly in the case of briging, sending collectibles and mutli transactions.

See:
https://github.com/status-im/status-mobile/blob/develop/src/status_im/contexts/wallet/send/transaction_confirmation/view.cljs#L131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briansztamfater briansztamfater

Labels
E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes E:Mobile Wallet Release 1.27 all tasks for 1.27 related to wallet feature feature requests high-priority
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: calculate and show max fees on transaction confirmation page status-im/status-mobile
2 participants
@briansztamfater @J-Son89