Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message not displayed if custom value higher than entered value in routes generation page #20498

Open
vkjr opened this issue Jun 18, 2024 · 0 comments · May be fixed by #20519
Open

Warning message not displayed if custom value higher than entered value in routes generation page #20498

vkjr opened this issue Jun 18, 2024 · 0 comments · May be fixed by #20519

Comments

@vkjr
Copy link
Contributor

vkjr commented Jun 18, 2024

Followup to #20413

Steps:

  1. Go to the routes generation page
  2. Enter the value that is available on at least one network
  3. Long press on the network when the route is built
  4. Enter a value higher than the entered value on the routes generation page or higher than the maximum available value.

Actual result:

"This value is higher than entered send amount" is not shown

Expected result:

A warning message "This value is higher than entered send amount" should be displayed in cases:

  • If the custom input is defined as 1 ETH and the routes generation value is defined as 0.9 ETH,
  • If the value in custom input is higher than routes generation value and higher than amount available for this particular network.

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17
@vkjr vkjr self-assigned this Jun 18, 2024
@VolodLytvynenko VolodLytvynenko changed the title Lock network amount: "not enough gas" caution is not shown Warning message not displayed if custom value higher than entered value in routes generation page Jun 19, 2024
@churik churik added the T:mobile-wallet-core issues for mobile wallet core team label Jun 20, 2024
@churik churik added this to the 2.30.0 Beta milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

2 participants