Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamps for messages doesn't match real time if user send message from device with custom time #6419

Closed
churik opened this issue Oct 19, 2018 · 3 comments

Comments

@churik
Copy link
Member

churik commented Oct 19, 2018

Description

Type: Bug
Summary: when anybody send a message from device with custom time (not another timezone, but custom time, i.e. when there is 10:00 UTC, and user set 09:45) - timestamps for such messages are shown with difference in minutes from nearest timezone, so in chat it looks like wrong message ordering (but it is not, wrong are message timestamps)

Expected behavior

timestamps for messages are set according to real message ordering and receiver time settings;

Actual behavior

timestamps for messages sent from device with custom time don't match real time
us_t

Reproduction

Prerequisites: for User A timezone and time is set automatically; for User B time is custom and set 10 minutes earlier)

  • User A: open Status, join any public channel (i.e. #chuone), send message
  • User B: open Status, join any public channel (i.e. #chuone), send message
  • User A: check chat history

Additional Information

  • Status version: nightly 19/10/2018
  • Operating System: Android, iOS, desktop
@SlizkovaGanna
Copy link

Reproduces for me also

image

@yenda yenda self-assigned this Dec 12, 2018
@yenda yenda added this to Watching in Core Chat Dec 12, 2018
@0xc1c4da
Copy link
Contributor

➤ Hester Bruikman commented:

Data sync might improve situation; still inherent to peer-to-peer network.

Can give impression that connectivity is lost even though messages was received, but message order got displaced. How to make sure it's clear that a dated messages is received.

Compare timestamps (local + Whisper timestamp). Define behavior for message based on threshold while preventing 'faking' of historic messages.

@churik
Copy link
Member Author

churik commented Jan 7, 2020

Not reproducible anymore

@churik churik closed this as completed Jan 7, 2020
Core Chat automation moved this from Watching to Done Jan 7, 2020
@StatusWrike StatusWrike changed the title Timestamps for messages doesn't match real time if user send message from device with custom time Timestamps for messages doesn't match real time if user send message from device with custom time Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core Chat
  
Done
Development

No branches or pull requests

5 participants