Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status marked as battery draining app on Android Samsung S6 #6447

Closed
oskarth opened this issue Oct 22, 2018 · 15 comments
Closed

Status marked as battery draining app on Android Samsung S6 #6447

oskarth opened this issue Oct 22, 2018 · 15 comments

Comments

@oskarth
Copy link
Contributor

oskarth commented Oct 22, 2018

Problem

Status is marked as a battery draining app by App power monitor on Android. This is obviously a big problem as people will remove apps that drain too much problems. It appears it is due to using battery in the background, unlike other apps.

This problem happens within a few minutes of launching the app and has been reported by many users.

Implementation

Do whatever is necessary to get rid of this.

Acceptance Criteria

Make it disappear consistently.

Notes

This has been reported so many times it isn't funny, and it is so easy to detect.

Future Steps

Ensure automatic tests of this.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 22, 2018

If someone is willing to bet $50 or more they fixed the problem dac-zero (https://discuss.status.im/t/sitg-experiment-2-dac0-liquid-pledging/426) is willing to pay $500, provided you opted in to the SNT pool (https://discuss.status.im/t/be-part-of-the-dao-nao/507).

Status.im
Welcome to Skin In The Game experiment two! While sitg-one is ongoing, this time we’ll doing something a bit differently, namely play around with a liquid pledging model. As before, we assume a trusted setup (see previous post as to why this is an OK assumption for now). This experiment directly targets Q3 OKRs re Liquid pledging. Pre-requisite reading Future of Giving: https://medium.com/giveth/what-is-the-future-of-giving-d50446b0a0e4 Overview of liquid pledging: https://wiki.giveth.io/doc...
Status.im
Organizations in the future will be permissionless. They will enable individuals within the organization to fund innovative ideas without any oversight, or permission required from ‘management’. This is another experiment for testing these new funding methods on a small scale, to help us iterate towards a less centralized compensation model. The goal here is to make compensation more transparent, meritocratic, and more profitable for core contributors. While simultaneously making core contribut...

@lukaszfryc
Copy link
Contributor

It appears it is due to using battery in the background, unlike other apps.

@mandrigin @yenda do we have a clear understanding what is causing it? If not, how we can research it?

@oskarth
Copy link
Contributor Author

oskarth commented Oct 22, 2018

It'd also be great to understand why this wasn't an acceptance criteria for the swarm/team that dealt with this over a period of a few months. I know we made huge improvements, but this seems like a pretty clear cut case of either it works (according to Android battery monitor, which end users trusts) or it doesn't?

@oskarth
Copy link
Contributor Author

oskarth commented Oct 22, 2018

^ @chadyj fyi

@mandrigin
Copy link
Contributor

@oskarth thanks for creating this issue, finally.

I'll document my decision chain here.

unlike on iOS, on Android, devp2p node keeps running in the background, that helps Whisper to receive messages even when the app is minimized w/o mailservers.

That is what probably causes SGS app power monitor to freak out. So, there is a compromise between receiving more messages w/o mailservers and app power monitor messages.
I don't think there is a way to keep p2p connections alive in any way in background if we want to address this issue (the required heartbeat is way shorter than the time needed for the battery monitor to stop complaining).

So, we can either keep doing what we are doing now, or change the behaviour and stop the node when the app is backgrounded.
Maybe with the new changes to the mailservers (batch receiving, etc), it might make sense to completely switch to them.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 22, 2018

I think it makes sense to do what default Android and iOS apps do and power off by default. Can be advanced mode to turn on battery intensive background fetching.

What do normal mail apps do?

@mandrigin
Copy link
Contributor

@oskarth normal apps don't keep multitudes of p2p connections. It's hell of a lot easier not to keep a connection if you only make requests to some rest/soap/graphql APIs.
They can just sync once a few minutes because the response time is very predictable.

@mandrigin
Copy link
Contributor

but sure, we can shutdown the node, it will just take a few more seconds to get your messages when you return from background.

@oskarth
Copy link
Contributor Author

oskarth commented Nov 8, 2018

No takers for the offer yet. Since I believe this should be a core responsibility, and SNT pool looks likely to change with move to Network, I'm hereby revoking the above extra bounty.

(We can still use a bounty for this, just think there are more valuable things for me to stake my own personal funds to further Status right now. It also makes my own fund management easier so I don't hand out IOUs everywhere :P).

@status-github-bot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Swader
Copy link
Contributor

Swader commented Feb 6, 2019

Still active

@status-github-bot status-github-bot bot removed the stale label Feb 6, 2019
@Swader
Copy link
Contributor

Swader commented Feb 19, 2019

@hesterbruikman
Copy link
Contributor

@Serhy do you know if this is still relevant? I can only test Android 7 :/

@Serhy
Copy link
Contributor

Serhy commented May 4, 2020

Can't reproduce with Android 6.0.1 (Galaxy Note 4)
Also Samsung S6 comes with Android 5 which we do not support.
We didn't have any reports for draining battery after V1 (and especially after Waku upgrade).
This is not relevant anymore, @hesterbruikman

@Serhy Serhy closed this as completed May 4, 2020
@hesterbruikman
Copy link
Contributor

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Mobile Client Team
  
Awaiting triage
Development

No branches or pull requests

7 participants