Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same UI and navigation on desktop and mobile #7399

Closed
yenda opened this issue Feb 1, 2019 · 3 comments · Fixed by #7551 or #8630
Closed

Use same UI and navigation on desktop and mobile #7399

yenda opened this issue Feb 1, 2019 · 3 comments · Fixed by #7551 or #8630
Projects
Status Desktop

Comments

@yenda
Copy link
Contributor

yenda commented Feb 1, 2019 •
edited by 0xc1c4da

Problem

Desktop is currently using a different set of screens and navigation system, which adds up to the burden of maintaining the platform.

Implementation

Check what is required to have desktop work with the current mobile screens. We can use conditionals like we already have for ios/android for platform specific things but overall that would remove the only limitation we have for having features released on both platforms simultaneously.

Acceptance Criteria

Desktop doesn't use it's own screens anymore

Related issues

Notes

  • react-navigation might need to be implemented for the desktop platform?
@yenda yenda added the desktop label Feb 1, 2019
@yenda yenda added the proposal label Feb 1, 2019
@vkjr vkjr added this to In Progress in Status Desktop Feb 6, 2019
@vkjr vkjr mentioned this issue Mar 19, 2019
Merged
@0xc1c4da 0xc1c4da removed their assignment Apr 1, 2019
@vkjr vkjr removed the proposal label Apr 18, 2019
@0xc1c4da
Copy link
Contributor

➤ Oskar T commented:

Is this really Eric D? Not Volodymyr Kozieiev?

@vkjr
Copy link
Contributor

vkjr commented Apr 30, 2019

Eric created this long ago as a proposal, so I decided not to create a new github issue for ongoing work since this one already describes the problem.

@vkjr vkjr closed this as completed in #7551 May 3, 2019
Status Desktop automation moved this from In Progress to Done May 3, 2019
@vkjr vkjr reopened this May 14, 2019
@vkjr
Copy link
Contributor

vkjr commented May 14, 2019

This issue was closed because referenced in #7551 PR. But for now mobile UI merged under flag, so we can't call this issue closed.

@vitvly vitvly removed their assignment Aug 29, 2019
@vkjr vkjr mentioned this issue Sep 30, 2019
Merged
@vkjr vkjr closed this as completed in #8630 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Status Desktop
Done
Milestone
No milestone
7 participants
@mandrigin @vitvly @yenda @rasom @0xc1c4da @vkjr @annadanchenko