Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error message if provide wrong mailserver or bootnode url #7752

Closed
annadanchenko opened this issue Mar 18, 2019 · 6 comments · Fixed by #7780
Closed

No error message if provide wrong mailserver or bootnode url #7752

annadanchenko opened this issue Mar 18, 2019 · 6 comments · Fixed by #7780
Assignees

Comments

@annadanchenko
Copy link

annadanchenko commented Mar 18, 2019

Description

Type: Bug

Summary: There is no error message if provided url is considered as invalid. Save button is not enabled and user has no clues on what's wrong and what is expected format (e.g. as in #7746)

We can show error above the filed with a message on what's wrong and share some expected format for url... Or can add a link to tech doc where adding custom mailserver and sample of the url format/example are provided...

Expected behavior

Explanation on why the provided url is invalid and what's the valid format

Actual behavior

No error message

Reproduction

For mailserver:

  • Open Status -> Profile -> Advanced -> Mailserver
  • Turn off automatic selection
  • Tap + to add custom mailserver
  • provide Name and type "invalid" into mailserver address field
  • Check Save button and if there is any error message

IMG_5969

For bootnode:

  • enable bootnode in Profile -> Advanced -> Bootnodes
  • sign in and go again to Profile -> Advanced -> Bootnodes
  • Tap + to add bootnode
  • provide Name and type "invalid" into bootnode address field

Additional Information

  • Status version: all previous releases and current nightly
  • Operating System: Android and iOS

Logs

...
@churik
Copy link
Member

churik commented Mar 18, 2019

close to #7333 - but seems there is no error anymore, before it was Re-matches must match again a string

@annadanchenko annadanchenko changed the title No error message if provide wrong mailserver url No error message if provide wrong mailserver or bootnode url Mar 18, 2019
@rasom rasom self-assigned this Mar 20, 2019
@rasom
Copy link
Member

rasom commented Mar 20, 2019

is this enough?

@mandrigin
Copy link
Contributor

@rasom also, as a placeholder, can we provide an example enode id, so user knows what to enter there?

@rasom
Copy link
Member

rasom commented Mar 20, 2019

I'm not sure it will fit well in that tooltip, but I'll try

@rasom
Copy link
Member

rasom commented Mar 21, 2019

@mandrigin @annadanchenko what about this one?

@mandrigin
Copy link
Contributor

@rasom I thought about it being in a placeholder of the text field, just like “specify a name”.
It would still be cool to add that, so when a person opens it for the first time, they know what to do.

And let’s keep this updated error message too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants