Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRCode transaction don't detects default account balance #9380

Closed
3esmit opened this issue Nov 3, 2019 · 10 comments
Closed

QRCode transaction don't detects default account balance #9380

3esmit opened this issue Nov 3, 2019 · 10 comments

Comments

@3esmit
Copy link
Member

3esmit commented Nov 3, 2019

Bug Report

the following payment link ethereum:0x3d597789ea16054a084ac84ce87f50df9198f415?value=1e15
image

Dont work, it scans and fills the transaction screen but it says no funds, even when there are funds.

Problem

Probably caused by the change to multiaccounts.

Expected behavior

Lookup balances from default account and allow transfer.

Actual behavior

Balances not looking up, transfer is not possible.

Notes

For the developer who will be investigating. Is it related to another PR? Tips on where to start?

Acceptance Criteria

link ethereum:0x3d597789ea16054a084ac84ce87f50df9198f415?value=1e15 should be able to be processed

Reproduction

  • Open Status
  • Scan QR Code from this document
  • Step 3, etc.

Additional Information

@3esmit 3esmit added the bug label Nov 3, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 2000.0 SNT (81.1 USD @ $0.04/SNT) attached to it as part of the status-im fund.

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 2000.0 SNT (81.1 USD @ $0.04/SNT) attached to it as part of the status-im fund.

@gitcoinbot
Copy link

gitcoinbot commented Nov 3, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 7 months from now.
Please review their action plans below:

1) acolytec3 has been approved to start work.

Continue work on QR code methods. Should be able to apply fix either in fill-results-from-url or extract-details.

Learn more on the Gitcoin Issue Details page.

@3esmit
Copy link
Member Author

3esmit commented Nov 3, 2019

@acolytec3 feel free to fix this in the same PR you are working with other QRcode stuff, as this issue is a blocker for properly testing #9240 or open a separate if you prefer.

@gitcoinbot
Copy link

@acolytec3 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@acolytec3
Copy link
Contributor

@gitcoinbot Yes, still working on it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 2000.0 SNT (27.42 USD @ $0.01/SNT) has been submitted by:

  1. @acolytec3

@3esmit please take a look at the submitted work:


@3esmit
Copy link
Member Author

3esmit commented Nov 11, 2019

Still happens in Commit: 1cdfff0

I notice that, when using the Send button from the wallet, it works fine.

How to reproduce:

  1. Open Status
  2. (From the Chats Tab) tap on the + plus button
  3. Tap on Scan QR code
  4. It dont works.

@churik
Copy link
Member

churik commented Feb 26, 2020

The value parameter is still doesn't work, but I didn't experience this issue again.
Will open separate issue with value

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 2000.0 SNT (24.1 USD @ $0.01/SNT) attached to this issue has been approved & issued to @acolytec3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants