Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can double purchase a sticker pack while Tx is pending #9754

Closed
rachelhamlin opened this issue Jan 6, 2020 · 14 comments · Fixed by status-im/status-go#1830 or #9965
Closed

User can double purchase a sticker pack while Tx is pending #9754

rachelhamlin opened this issue Jan 6, 2020 · 14 comments · Fixed by status-im/status-go#1830 or #9965

Comments

@rachelhamlin
Copy link
Contributor

Bug Report

Problem

  • Paid sticker packs require Tx mined to install
  • No indication of pending Tx in Status wallet
  • If user refreshes app, sticker pack no longer shows spinning loader (indicating Tx mining)
  • User can then purchase sticker pack again—nothing stops them from making two Txs for the same pack

Expected behavior

Pending sticker purchase persists even after app is closed and reopened.

Actual behavior

If app is restarted, sticker store forgets that a Tx is pending for a purchase pack. User can pay for the same the pack again.

Tested on iOS nightly.

@rachelhamlin rachelhamlin added this to To Do - P0 in Core via automation Jan 6, 2020
@rachelhamlin rachelhamlin moved this from To Do - P0 to To Do - P1 in Core Jan 6, 2020
@rachelhamlin rachelhamlin added this to Open, no worker assigned in Status Bounty Tracker Jan 6, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

@mul53 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@mul53
Copy link

mul53 commented Jan 12, 2020

Hey still working on this, I was working through starting up the development environment. Now it’s up how can I reproduce the bug above.

@StatusSceptre
Copy link
Member

Awesome @mul53 - let us know if you have any questions.

@mul53
Copy link

mul53 commented Jan 13, 2020

@mul53 I have a question regarding a bug. How do i reproduce it? Sorry It's my first time navigating status(by the way, Awesome UI).

@StatusSceptre
Copy link
Member

Thanks. :) Are you on the develop build @mul53? Can you see the sticker icon in a chat? You will need some SNT to purchase the sticker pack that is for sale. You can send me your ETH address so I can send you some for testing.

image

@mul53
Copy link

mul53 commented Jan 17, 2020

@StatusSceptre thanks, Found it. Though when i click on the Get Stickers link i get this and here is my ETH address.
Screenshot_1579267863

@rachelhamlin
Copy link
Contributor Author

Yesss thank you @vkjr

@vkjr
Copy link
Contributor

vkjr commented Mar 19, 2020

@rachelhamlin, I think we should close this issue on gitcoin since it is closed already.

@rachelhamlin
Copy link
Contributor Author

Will do @vkjr

@gitcoinbot
Copy link

gitcoinbot commented Apr 20, 2020

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 2 years ago.
Please review their action plans below:

1) bild96 has started work.

This issue still exists? if yes, could I go through it and found out the reaction.

Learn more on the Gitcoin Issue Details page.

@StatusSceptre
Copy link
Member

Hi @Bild96 - sorry, but this is actually closed.

@StatusSceptre
Copy link
Member

Now closed on Gitcoin

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 100.0 DAI (100.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
Done
Status Bounty Tracker
  
Open, no worker assigned
5 participants