Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show ENS name in profile unless Tx is confirmed #9912

Closed
rachelhamlin opened this issue Jan 24, 2020 · 2 comments · Fixed by #10422
Closed

Do not show ENS name in profile unless Tx is confirmed #9912

rachelhamlin opened this issue Jan 24, 2020 · 2 comments · Fixed by #10422
Assignees
Projects

Comments

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Jan 24, 2020

Problem

If my ENS Tx fails, it seems to get stuck in a pending state on my profile, at least for a given session. It would be better that we don't display it on the profile until the Tx is mined.

Another user can register the name while I'm waiting because my Tx has, in fact, failed.

Acceptance Criteria

Current state

Success??

Wait a minute... (What I think is happening based on ENS screen)

What actually happened

Preferred implementation

  • No ENS name on my profile and I still see ENS usernames as my entry point
  • Ideally, we 1) add a pending state for the list usernames. It should indicate that a name is pending somewhere on this page.
    1. We add a state for a failed transaction.

This screen can stay like this until names are confirmed

This screen should have a pending and failed Tx state, ideally

@rachelhamlin rachelhamlin added this to To Do - P0 in Core via automation Jan 24, 2020
@StatusSceptre StatusSceptre moved this from To Do - P0 to To Do - P1 in Core Jan 27, 2020
@rachelhamlin rachelhamlin moved this from To Do - P1 to To Do - P2 in Core Apr 10, 2020
@jrainville jrainville self-assigned this Apr 17, 2020
@iurimatias iurimatias added this to the Desktop - Sprint 1 milestone Apr 27, 2020
@kmoll
Copy link

kmoll commented May 19, 2020

I am experiencing this too, although it seems to be more than just a given session. Is there a way to release the name if the transaction fails?

@henrystats
Copy link

Issue also affects sharing of personal link. If your ens name is pending, it still generates a link with your pending ens name.

i.e https://join.status.im/u/henrystats.stateofus.eth

Core automation moved this from Backlog to Done Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
Done
Development

Successfully merging a pull request may close this issue.

7 participants