Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread badge counter doesn't fit large numbers #2900

Closed
dmitryn opened this issue Jan 4, 2018 · 2 comments
Closed

Unread badge counter doesn't fit large numbers #2900

dmitryn opened this issue Jan 4, 2018 · 2 comments
Labels
bounty good first issue medium-priority
Projects
Status Bounty Tracker

Comments

@dmitryn
Copy link
Contributor

dmitryn commented Jan 4, 2018 •
edited

Description

Type: Bug

Summary: Unread messages counter badge doesn't fit large numbers on chat list screen.

Expected behavior

ios: number is inside the badge
android: number is not cut off

Actual behavior

ios: Number is outside the badge
android: number cut off (maximum 3 symbols shown)

Reproduction

ios

  • Open Status
  • Have chat with more than 300+ unread messages (join #status public channel for example)
  • Go to chat list
  • Number is out of badge container

android

  • Open Status
  • Have chat with 1234 (any 4-digit number) unread messages (join #status public channel for example)
  • Go to chat list
  • You will see "123" unread counter, not "1234"

Operating System: iOS (simulator) and Android (simulator)

screenshot 2018-01-04 11 46 11

screenshot 2018-01-04 13 30 23
@andytudhope
Copy link
Contributor

andytudhope commented Jan 4, 2018 •
edited

Pretty cool that there were 357 messages in the status chat this morning though 😉 🎉 Can we maybe bounty this @dmitryn?

@status-open-bounty
Copy link

status-open-bounty commented Jan 4, 2018 •
edited

Balance: 0.000000 ETH
Contract address: 0x976f8e12fa1494eadfae905e1a625f56027e8d97
Network: Mainnet
Paid to: foopang
Visit https://openbounty.status.im to learn more.

@foopang foopang mentioned this issue Jan 4, 2018
Merged
@flexsurfer flexsurfer added this to REVIEW in Pipeline for QA via automation Jan 5, 2018
@flexsurfer flexsurfer moved this from REVIEW to TO TEST in Pipeline for QA Jan 5, 2018
@andytudhope andytudhope added this to PR Submitted in Status Bounty Tracker Jan 5, 2018
@andytudhope andytudhope moved this from PR Submitted to Ready for Testing in Status Bounty Tracker Jan 9, 2018
@asemiankevich asemiankevich moved this from TO TEST to MERGE in Pipeline for QA Jan 12, 2018
@oskarth oskarth removed this from MERGE in Pipeline for QA Jan 12, 2018
oskarth pushed a commit to foopang/status-react that referenced this issue Jan 12, 2018
@foopang @oskarth
[Fix status-im#2900] Unread badge counter doesn't fit large numbers
343f5c1 
Signed-off-by: Oskar Thoren <ot@oskarthoren.com>
@andytudhope andytudhope moved this from Ready for Testing to Merged & Confirmed in Status Bounty Tracker Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty good first issue medium-priority
Projects
Status Bounty Tracker
  
Merged & Confirmed
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitryn @oskarth @andytudhope @status-open-bounty