Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be redirected to wallet onboarding before signing transaction in dapp #4724

Closed
lukaszfryc opened this issue Jun 12, 2018 · 0 comments · Fixed by #5250
Closed
Assignees

Comments

@lukaszfryc
Copy link
Contributor

lukaszfryc commented Jun 12, 2018

Description

Type: Bug

Summary: If user haven't seen wallet onboarding yet, he should be redirected to it before signing transaction in dapp. Currently, he can sign it before seeing the wallet onboarding which is incorrect.

Also, currently, when he finally goes to wallet and finishes the onboarding, an empty send transaction screen is shown for no reason.

Expected behavior

User is redirected to wallet onboarding before dapp signing transaction. It's already work like this for "/send" in chat.

Actual behavior

User can sign dapp transaction before finishing wallet onboarding.

Reproduction

  • Install and open Status
  • Create a new account
  • Switch to Ropsten and enable dev mode
  • Sign a transaction in the test dapp. For instance, request STT
  • Go to wallet and complete onboarding

Additional Information

  • Status version: nightly, 12 June
  • Operating System: Android, iOS
@lukaszfryc lukaszfryc changed the title Empty send transaction screen is shown after wallet onboarding User should be redirected to wallet onboarding before signing transaction in dapps Jun 12, 2018
@lukaszfryc lukaszfryc changed the title User should be redirected to wallet onboarding before signing transaction in dapps User should be redirected to wallet onboarding before signing transaction in dapp Jun 12, 2018
@goranjovic goranjovic moved this from Next to Backlog/Bugs in Wallet Maintenance Jun 22, 2018
@goranjovic goranjovic moved this from Backlog/Bugs to Next in Wallet Maintenance Jun 25, 2018
@goranjovic goranjovic moved this from Next to Beta X in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from Beta X to In progress in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from In progress to Beta X in Wallet Maintenance Jul 5, 2018
@goranjovic goranjovic moved this from Beta X to In progress in Wallet Maintenance Jul 6, 2018
@goranjovic goranjovic self-assigned this Jul 6, 2018
@goranjovic goranjovic moved this from In progress to Shortlist in Wallet Maintenance Jul 16, 2018
@goranjovic goranjovic moved this from Shortlist to Backlog/Bugs in Wallet Maintenance Jul 16, 2018
@goranjovic goranjovic moved this from Backlog/Bugs to In progress in Wallet Maintenance Jul 21, 2018
@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Jul 22, 2018
jeluard pushed a commit that referenced this issue Jul 31, 2018
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
Wallet Maintenance automation moved this from Review/Testing to Done Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants