-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User should be redirected to wallet onboarding before signing transaction in dapp #4724
Projects
Comments
goranjovic
added a commit
that referenced
this issue
Jul 25, 2018
goranjovic
added a commit
that referenced
this issue
Jul 27, 2018
goranjovic
added a commit
that referenced
this issue
Jul 30, 2018
jeluard
pushed a commit
that referenced
this issue
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Type: Bug
Summary: If user haven't seen wallet onboarding yet, he should be redirected to it before signing transaction in dapp. Currently, he can sign it before seeing the wallet onboarding which is incorrect.
Also, currently, when he finally goes to wallet and finishes the onboarding, an empty send transaction screen is shown for no reason.
Expected behavior
User is redirected to wallet onboarding before dapp signing transaction. It's already work like this for "/send" in chat.
Actual behavior
User can sign dapp transaction before finishing wallet onboarding.
Reproduction
Additional Information
The text was updated successfully, but these errors were encountered: