Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist state for browser session [Android] #5278

Closed
rachelhamlin opened this issue Jul 24, 2018 · 2 comments
Closed

Persist state for browser session [Android] #5278

rachelhamlin opened this issue Jul 24, 2018 · 2 comments
Projects
Core DApps

Comments

@rachelhamlin
Copy link
Contributor

User Story

As a user, I want to be able to switch between DApps, chat, and wallet without losing my place in a DApp, so that I can multi-task.

Description

Type: Feature

Summary: Maintain state after a user has exited a DApp, so that when they reopen that instance of the browser, their data or activity is not lost.

Expected behavior

I select two tokens in DDEX and edit the Limit Price.

I close DDEX to do something else in Status (chat, open another DApp, etc.).

I click on the browser session on my home screen to reopen DDEX, and my chosen token choice and Limit Price are still there.

Actual behavior

In the DDEX example, Limit Price is not remembered and I have to re-enter it.

In other DApps I may have to log back in, select the currencies again, etc.

Reproduction

Airswap is a good example:

  • Open Airswap
  • Select a token to buy
  • "Connect using Status"
  • Sign message
  • Enter token amount
  • Close app
  • Reopen browser instance
@rachelhamlin rachelhamlin added this to Next in Core DApps Jul 24, 2018
@jeluard jeluard moved this from Next to In progress in Core DApps Jul 25, 2018
rasom added a commit that referenced this issue Jul 30, 2018
@rasom
[#5278][Android] persist webview state during session
f67373c
@rasom rasom mentioned this issue Jul 30, 2018
Merged
rasom added a commit that referenced this issue Aug 2, 2018
@rasom
[#5278][Android] persist webview state during session
36473fc
@rasom rasom mentioned this issue Aug 13, 2018
Closed
rasom added a commit that referenced this issue Aug 15, 2018
@rasom
[#5278][Android] persist webview state during session
48d81a4
jakubgs added a commit that referenced this issue Aug 16, 2018
@jakubgs
merged squashed develop
bd8c733 
Squashed commit of the following:

commit 24db421
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Thu Aug 16 15:35:31 2018 +0200

    Don't lock Jenkins nodes for too long if possible (#desktop).

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

commit e8ab892
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Thu Aug 16 11:46:42 2018 +0200

    Fix Slack messages for builds.

    1) Fill in apkUrl where needed so it is not empty;
    2) Remove unused variables.

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

commit 854aceb
Author: jhe <jan.herich@gmail.com>
Date:   Thu Aug 16 11:29:20 2018 +0200

    Remove jail + Status.js API

    Signed-off-by: jhe <jan.herich@gmail.com>

commit 43263a9
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Tue Aug 14 18:38:21 2018 +0200

    Post-fastlane cleanup. Remove unnecessary plist files.

    This functionality is handled in `fastlane/Fastfile` now.

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

commit e3aa8a5
Author: Max Risuhin <risuhin.max@gmail.com>
Date:   Thu Aug 16 00:27:13 2018 +0300

    Thread safe access to log messages list

commit 915a8e7
Author: Max Risuhin <risuhin.max@gmail.com>
Date:   Thu Aug 16 01:54:17 2018 +0300

    Publish GitHub PR page comment on desktop build status change

commit 31924f1
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Wed Aug 15 16:13:27 2018 +0200

    Workaround to support parallel iOS builds on the same Jenkins runner.

    Realm download script didn't support it, so the simplest solution is
    just to patch it and replace before iOS builds.

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

commit 6e80321
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Wed Aug 15 08:15:45 2018 +0200

    Fix diawi upload for nightlies.

    BRANCH_NAME isn't set for nightly builds, fix fastlane script accordingly.

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>

commit c57a1f4
Author: Anton Danchenko <ant.danchenko@gmail.com>
Date:   Fri Aug 10 13:09:19 2018 +0300

    alert text to error message, removed locator text from the message, reduced running time

    Signed-off-by: Anton Danchenko <ant.danchenko@gmail.com>

commit dda7cae
Author: Goran Jovic <goranjovic@gmail.com>
Date:   Sun Aug 12 11:33:55 2018 +0200

    bug #5058 - aligned words in recovery backup phrase screen

    Signed-off-by: Goran Jovic <goranjovic@gmail.com>

commit 48d81a4
Author: Roman Volosovskyi <roman.wolosovskyi@gmail.com>
Date:   Mon Jul 30 16:38:57 2018 +0300

    [#5278][Android] persist webview state during session

commit 434046f
Author: Igor Mandrigin <i@mandrigin.ru>
Date:   Tue Aug 14 18:24:48 2018 +0200

    Upload apk to Sauce Labs using fastlane.

    Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
@rasom rasom removed their assignment Sep 3, 2018
@rachelhamlin rachelhamlin changed the title Persist state for browser session Persist state for browser session [Android] Sep 6, 2018
@rachelhamlin rachelhamlin moved this from In progress to Done in Core DApps Sep 6, 2018
@status-github-bot
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@status-github-bot
Copy link

This issue has been automatically closed. Please re-open if this issue is important to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Core DApps
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rasom @rachelhamlin