Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate words when recovery phrase is entered and show warning if they do not match expected words #5310

Closed
annadanchenko opened this issue Jul 26, 2018 · 1 comment · Fixed by #5494

Comments

@annadanchenko
Copy link

annadanchenko commented Jul 26, 2018

Description

Type: Feature

Summary: Other account will be recovered if user makes a typo when entering a word in Recovery phrase. We can introduce validation of the entered words to see if they are found in https://github.com/status-im/status-go/blob/52cdcf8f0f1127f5ee694f39086a9e4df54174e6/extkeys/mnemonic.go#L97 If not then we can show an extra warning to the user or highlight "wrong" words but give user a final choice to decide if it's ok to restore account with "unexpected" words or not

Several users reported "lost funds" as wrong account was recovered. We can help to prevent it with such validation (even minimalistic UI would be better then seeing 0 instead of 5 ETH on recovered account)

GitHub
status-go - The Status module that consumes go-ethereum
@denis-sharypin
Copy link

My proposal would be:

  1. Start checking words using our list right after this input is not active and show this warning if at least one word is wrong.

screenshot 2018-08-09 10 34 06

  1. If a user decides to proceed she will get this

screenshot 2018-08-09 11 26 13

There is some possibility to meet people that not using standard words, but let's assume that they know what they are doing and keep the flow above since it's still possible to recover an account.

Please check the copy @obi2020

@goranjovic goranjovic moved this from Shortlist to In progress in Wallet Maintenance Aug 12, 2018
@goranjovic goranjovic self-assigned this Aug 12, 2018
@goranjovic goranjovic moved this from In progress to Review/Testing in Wallet Maintenance Aug 14, 2018
goranjovic added a commit that referenced this issue Aug 23, 2018
…bug #5353

Signed-off-by: Goran Jovic <goranjovic@gmail.com>
Wallet Maintenance automation moved this from Review/Testing to Done Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants