Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Management #585

Closed
0xc1c4da opened this issue Dec 26, 2016 · 10 comments
Closed

Contact Management #585

0xc1c4da opened this issue Dec 26, 2016 · 10 comments
Assignees
Milestone

Comments

@0xc1c4da
Copy link
Contributor

at the moment it is not clear how we should delete or move a contact between groups.

we also have no way to create/remove/edit groups

@andmironov
Copy link

andmironov commented Dec 28, 2016

What do you think of this?

contact_management

@0xc1c4da
Copy link
Contributor Author

looks great, how does add group look on Android and iOS? how do we delete a group?

@andmironov
Copy link

UPD
contact_management2

@0xc1c4da
Copy link
Contributor Author

nice! okay I assume deleting a contact froma group would make them ungrouped ? then deleting a contact from ungrouped would delete them?

@andmironov
Copy link

Yep, also "ungrouped" would be useful for people who just don't like grouping. Notice that the ungrouped group can also be sorted, but does not have a header in the list (Like all other groups have: Dapps 45 or Favourites 14) what do you think about that?

@0xc1c4da
Copy link
Contributor Author

love it!

@andmironov
Copy link

Great! I will add it to Zepling then

@andmironov
Copy link

andmironov commented Dec 29, 2016

All of them https://zpl.io/Z1Oh6MV
And I've also added them one by one with the contact-management_ prefix (13 screens)

@rabbit
Copy link

rabbit commented Jan 8, 2017

these look fantastic. a few suggestions to interpret as you wish:

  • if "delete group" does not delete the group then simplify the language and remove the hint. sounds like you mean to say "leave group"
  • in general destructive actions should have a little more space since mobile users may have large fingers or fumble, feels a bit tight between add group and delete group.
  • for the bottom menu bar, the singular "chat" sounds more like an action (ie: what do I want to do? chat. vs what do I want to do? chats.) contacts doesn't read that way to me.
  • might want to check with a color contrast app to ensure all the text is readable for those without clear vision or color blindness. that top right "Group Members: 3" the 3 looks borderline to me
  • love the way selection looks on list items (see? I can be nice)
  • there's no view for "add group members" but going on the plural of members I would expect the multiple select view, if it's a one at a time operation singularize it.
  • "Create Group" and "Change Group Order" both begin with "C" and end with "e". humans parse words predominantly by beginning and end letters, consider renaming "Change Group Order" to "Reorder Group" or similar to create more visual separation at a glance.

@0xc1c4da 0xc1c4da added the design label Jan 8, 2017
@0xc1c4da 0xc1c4da changed the title Contact Management designs Contact Management Feb 4, 2017
@0xc1c4da 0xc1c4da added the Epic label Feb 4, 2017
@0xc1c4da 0xc1c4da added this to the 0.9.4 milestone Feb 4, 2017
flexsurfer added a commit that referenced this issue Feb 5, 2017
@flexsurfer
Copy link
Member

flexsurfer commented Feb 5, 2017

Contacts screen

Search

  • search icon on search and delete on input
  • "live search" (filter)

New contact

  • done

New Group

  • done

Contacts List

  • selection (removed native toggle component)
  • search

Edit group

  • done

Reorder group
(requered new react native component react-native-sortable-listview)

  • done

flexsurfer referenced this issue Feb 6, 2017
flexsurfer referenced this issue Feb 10, 2017
flexsurfer referenced this issue Feb 12, 2017
flexsurfer referenced this issue Feb 13, 2017
…nto feature/contact-management-#585

# Conflicts:
#	src/status_im/contacts/handlers.cljs
flexsurfer referenced this issue Feb 14, 2017
…nto feature/contact-management-#585

# Conflicts:
#	src/status_im/android/core.cljs
#	src/status_im/android/platform.cljs
#	src/status_im/ios/core.cljs
#	src/status_im/ios/platform.cljs
#	src/status_im/new_group/handlers.cljs
#	src/status_im/new_group/styles.cljs
rasom added a commit that referenced this issue Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants