Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #5496] Added SuperRare NFT support #5686

Merged
merged 1 commit into from Aug 30, 2018
Merged

[Fixes #5496] Added SuperRare NFT support #5686

merged 1 commit into from Aug 30, 2018

Conversation

jeluard
Copy link
Contributor

@jeluard jeluard commented Aug 29, 2018

fixes #5496

Summary:

Added support for SuperRare NFT

status: ready

@jeluard jeluard self-assigned this Aug 29, 2018
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 29, 2018
flexsurfer
flexsurfer requested changes Aug 29, 2018
View reviewed changes
src/status_im/ui/screens/wallet/collectibles/events.cljs Outdated
@@ -19,7 +19,7 @@
(fn [{:keys [db]} [_ address {:keys [symbol amount] :as collectible}]]
(let [items-number (money/to-number amount)
loaded-items-number (count (get-in db [:collectibles symbol]))]
(merge (when (not= items-number loaded-items-number)
(merge (when true ;(not= items-number loaded-items-number)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

src/status_im/ui/screens/wallet/collectibles/events.cljs Outdated
(fn [{db :db} [_ symbol collectibles]]
{:db (update-in db [:collectibles symbol] merge collectibles)}))


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

src/status_im/utils/http.cljs Outdated
@@ -15,7 +15,8 @@
(post url data on-success nil))
([url data on-success on-error]
(post url data on-success on-error nil))
([url data on-success on-error {:keys [timeout-ms headers]}]
([url data on-success on-error {:keys [valid-response? timeout-ms headers]}]
(println "HEADERS" headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@jeluard jeluard force-pushed the #5496 branch 2 times, most recently from 59448ea to 3892fb9 Compare August 29, 2018 08:18
@jeluard
Copy link
Contributor Author

jeluard commented Aug 29, 2018

@flexsurfer Please take another look!

flexsurfer
flexsurfer approved these changes Aug 29, 2018
View reviewed changes
src/status_im/utils/ethereum/core.cljs
@@ -33,6 +33,10 @@
address
(str hex-prefix address))))

(defn naked-address [s]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naked-hex maybe more common?

src/status_im/ui/screens/wallet/collectibles/superrare/views.cljs
[react/image {:style (merge {:resize-mode :contain :width 100 :height 100} styles/details-image)
:source {:uri imageUri
:k 1.4}}]
[react/view {:flex 1 :justify-content :center}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to styles? ¯_(ツ)_/¯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we wasting energy creating dedicated style namespace for every views namespace, having to come up with names for styles, and in the end never reuse again because it is so specific ?
personally I would very much appreciate if we were doing the styling in-line, but ofc it is not always that easy and sometimes you have the defstyles macro for platform specific stuff so I don't have a strong opinion about it. But I sometime find it wasteful to follow the pattern that we have right now

@goranjovic
Copy link
Contributor

A ropsten collectible 😮 👍

@lukaszfryc lukaszfryc self-assigned this Aug 29, 2018
@lukaszfryc
Copy link
Contributor

lukaszfryc commented Aug 29, 2018 •
edited

Builds failed with

java.lang.IllegalArgumentException: Null value not allowed as an environment variable: BUILD_TYPE
	at hudson.EnvVars.put(EnvVars.java:359)
	at hudson.model.StringParameterValue.buildEnvironment(StringParameterValue.java:59)
	at hudson.model.ParametersAction.buildEnvironment(ParametersAction.java:145)
	at hudson.model.Run.getEnvironment(Run.java:2382)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.getEnvironment(WorkflowRun.java:513)
	at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:106)
	at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:67)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:303)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Finished: FAILURE

https://ci.status.im/job/status-react/job/pull%20requests/job/PR-5686/

I'm restarting manually

@lukaszfryc
Copy link
Contributor

@jeluard the build is failing on formatting. Could you check?

[mobile-android] Running shell script
+ lein cljfmt check
Updating hook:  pre-commit
src/status_im/ui/screens/events.cljs has incorrect formatting
--- a/src/status_im/ui/screens/events.cljs
+++ b/src/status_im/ui/screens/events.cljs
�[036m@@ -97,13 +97,13 @@�[0m
   (let [on-success #(re-frame/dispatch (success-event-creator %))
         on-error   #(re-frame/dispatch (failure-event-creator %))
         all-opts   (assoc opts
�[031m-                     :valid-response? response-validator�[0m
�[031m-                     :timeout-ms      timeout-ms)]�[0m
�[032m+                          :valid-response? response-validator�[0m
�[032m+                          :timeout-ms      timeout-ms)]�[0m
     (http/post url data on-success on-error all-opts)))
 
 (re-frame/reg-fx
�[031m-  :http-post�[0m
�[031m-  http-post)�[0m
�[032m+ :http-post�[0m
�[032m+ http-post)�[0m
 
 (re-frame/reg-fx
  :request-permissions-fx
1 file(s) formatted incorrectly
[Pipeline] }

@jeluard
Copy link
Contributor Author

jeluard commented Aug 29, 2018

@lukaszfryc Should be good now

yenda
yenda reviewed Aug 29, 2018
View reviewed changes
src/status_im/utils/http.cljs
(and ok? (valid-response? response))
ok?)]
[response-body ok?']))))))
(.then (fn [[response ok?]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for ?

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Aug 29, 2018
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #10

Mobile
Desktop

@lukaszfryc lukaszfryc moved this from TO TEST to IN TESTING in Pipeline for QA Aug 30, 2018
@lukaszfryc lukaszfryc moved this from IN TESTING to MERGE in Pipeline for QA Aug 30, 2018
@jeluard
[Fixes #5496] Added SuperRare NFT support
683e6b5 
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
@jeluard jeluard merged commit 683e6b5 into develop Aug 30, 2018
Pipeline for QA automation moved this from MERGE to DONE Aug 30, 2018
@status-comment-bot
Copy link

✅ CI BUILD SUCCESSFUL

Jenkins job: #12

Mobile
Desktop

@rasom rasom deleted the #5496 branch September 3, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenda yenda yenda left review comments

@goranjovic goranjovic goranjovic approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@janherich janherich Awaiting requested review from janherich

Assignees

@jeluard jeluard

@lukaszfryc lukaszfryc

Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for superrare NFT
6 participants
@jeluard @goranjovic @lukaszfryc @status-comment-bot @yenda @flexsurfer