Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style header group-chats #7269

Merged
merged 1 commit into from Jan 29, 2019
Merged

Style header group-chats #7269

merged 1 commit into from Jan 29, 2019

Conversation

cammellos
Copy link
Member

@cammellos cammellos commented Jan 15, 2019 •
edited

Style group chats according to https://www.figma.com/file/aS1ct66VQ6V0cio7vSqS8UoG/Chat?node-id=375%3A3842

Styles group chats according to designs.

What's missing

Currently no bold on username on chat notifications
Search bar
Group info styling

status: ready

@cammellos cammellos self-assigned this Jan 15, 2019
@status-github-bot
Copy link

status-github-bot bot commented Jan 15, 2019 •
edited by pedropombeiro

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jan 15, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jan 15, 2019 •
edited

Jenkins Builds

Click to see older builds
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 90ef640 #1 2019-01-15 08:51:34 ~14 min android-e2e 📦 package
✔️ 90ef640 #1 2019-01-15 08:51:50 ~14 min macos 📦 package
✔️ 90ef640 #1 2019-01-15 08:52:50 ~15 min android 📦 package
✔️ 90ef640 #1 2019-01-15 08:52:51 ~15 min ios-e2e 📦 package
✔️ 90ef640 #1 2019-01-15 08:54:07 ~16 min windows 📦 package
✔️ 90ef640 #1 2019-01-15 08:55:29 ~18 min ios 📦 package
✔️ 90ef640 #1 2019-01-15 09:09:17 ~32 min linux 📦 package
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3764cb5 #2 2019-01-15 12:25:46 ~15 min android-e2e 📦 package
✔️ 3764cb5 #2 2019-01-15 12:29:00 ~18 min ios 📦 package
✔️ 3764cb5 #2 2019-01-15 12:34:03 ~23 min macos 📦 package
✔️ 3764cb5 #2 2019-01-15 12:34:07 ~24 min ios-e2e 📦 package
✔️ 3764cb5 #2 2019-01-15 12:34:10 ~24 min android 📦 package
✔️ 3764cb5 #2 2019-01-15 12:36:37 ~26 min windows 📦 package
✔️ 3764cb5 #2 2019-01-15 12:37:13 ~27 min linux 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:10:57 ~13 min macos 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:12:25 ~14 min android 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:12:57 ~15 min ios-e2e 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:12:58 ~15 min android-e2e 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:13:35 ~16 min ios 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:14:20 ~16 min windows 📦 package
✔️ 5d71fc7 #3 2019-01-16 08:14:58 ~17 min linux 📦 package

@cammellos
Copy link
Member Author

cammellos commented Jan 15, 2019 •
edited by status-github-bot bot

@errorists I am working on styling group chats https://www.figma.com/file/aS1ct66VQ6V0cio7vSqS8UoG/Chat?node-id=375%3A3842
quick question, what should happen if the user clicks on "Decline invitation"? should we just delete the group chat?

Figma
Created with Figma

@errorists
Copy link
Contributor

@cammellos Yes, delete the group chat and return to home screen.

jeluard
jeluard approved these changes Jan 15, 2019
View reviewed changes
src/status_im/ui/screens/group/views.cljs Outdated
(defn number-of-participants-disclaimer [number-of-participants-available]
[react/view {:style styles/number-of-participants-disclaimer}
[react/text (if (> number-of-participants-available
0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pos? maybe?

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Jan 21, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@churik churik moved this from TO TEST to IN TESTING in Pipeline for QA Jan 23, 2019
@churik churik self-assigned this Jan 23, 2019
@churik
Copy link
Member

churik commented Jan 24, 2019

@cammellos would you mind to rebase it to current develop?
builds are 8 days old. Sorry for delay in testing.

@cammellos
Copy link
Member Author

@churik done, sorry for the delay, is building now

@status-im-auto
Copy link
Member

status-im-auto commented Jan 24, 2019 •
edited

Jenkins Builds

Click to see older builds (79)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a6103ee #4 2019-01-24 13:34:48 ~4 min android 📄 build log
✔️ a6103ee #4 2019-01-24 13:45:27 ~14 min ios 📦 package
✔️ a6103ee #4 2019-01-24 13:45:39 ~15 min ios-e2e 📦 package
✔️ a6103ee #4 2019-01-24 13:47:40 ~17 min macos 📦 package
✔️ a6103ee #4 2019-01-24 13:52:04 ~21 min linux 📦 package
✔️ a6103ee #4 2019-01-24 13:56:34 ~25 min windows 📦 package
✔️ a6103ee #4 2019-01-24 13:58:06 ~27 min android-e2e 📦 package
✔️ a6103ee #5 2019-01-24 14:51:19 ~18 min android 📦 package
✔️ 3bc546f #5 2019-01-25 08:31:57 ~13 min ios-e2e 📦 package
✔️ 3bc546f #5 2019-01-25 08:34:24 ~16 min macos 📦 package
✔️ 3bc546f #6 2019-01-25 08:34:33 ~16 min android 📦 package
✔️ 3bc546f #5 2019-01-25 08:35:05 ~16 min ios 📦 package
✔️ 3bc546f #5 2019-01-25 08:36:21 ~18 min android-e2e 📦 package
✔️ 3bc546f #5 2019-01-25 08:37:59 ~19 min windows 📦 package
✔️ 3bc546f #5 2019-01-25 08:38:07 ~19 min linux 📦 package
✔️ d4e5a57 #6 2019-01-25 09:14:45 ~13 min macos 📦 package
✔️ d4e5a57 #6 2019-01-25 09:15:33 ~14 min ios-e2e 📦 package
✔️ d4e5a57 #6 2019-01-25 09:16:54 ~15 min ios 📦 package
✔️ d4e5a57 #6 2019-01-25 09:19:32 ~18 min android-e2e 📦 package
✔️ d4e5a57 #7 2019-01-25 09:21:38 ~20 min android 📦 package
✔️ d4e5a57 #6 2019-01-25 09:23:52 ~22 min linux 📦 package
✔️ d4e5a57 #6 2019-01-25 09:23:52 ~22 min windows 📦 package
✔️ d4ad1dc #7 2019-01-28 07:48:21 ~13 min macos 📦 package
✔️ d4ad1dc #7 2019-01-28 07:49:08 ~14 min ios-e2e 📦 package
✔️ d4ad1dc #7 2019-01-28 07:49:58 ~15 min ios 📦 package
✔️ d4ad1dc #7 2019-01-28 07:52:53 ~18 min android-e2e 📦 package
✔️ d4ad1dc #8 2019-01-28 07:53:02 ~18 min android 📦 package
✔️ d4ad1dc #7 2019-01-28 07:53:42 ~18 min windows 📦 package
✔️ d4ad1dc #7 2019-01-28 07:56:26 ~21 min linux 📦 package
❌ ada947d #8 2019-01-28 12:04:14 ~3 min ios 📄 build log
❌ ada947d #8 2019-01-28 12:04:25 ~3 min macos 📄 build log
❌ ada947d #8 2019-01-28 12:05:14 ~4 min ios-e2e 📄 build log
❌ ada947d #9 2019-01-28 12:06:53 ~6 min android 📄 build log
❌ ada947d #8 2019-01-28 12:07:02 ~6 min android-e2e 📄 build log
❌ ada947d #8 2019-01-28 12:07:35 ~7 min windows 📄 build log
❌ ada947d #8 2019-01-28 12:07:41 ~7 min linux 📄 build log
✔️ 0dba438 #9 2019-01-28 13:20:44 ~14 min macos 📦 package
✔️ 0dba438 #9 2019-01-28 13:21:27 ~15 min ios-e2e 📦 package
✔️ 0dba438 #9 2019-01-28 13:21:54 ~15 min ios 📦 package
✔️ 0dba438 #10 2019-01-28 13:23:45 ~17 min android 📦 package
✔️ 0dba438 #9 2019-01-28 13:25:18 ~19 min android-e2e 📦 package
✔️ 0dba438 #9 2019-01-28 13:29:06 ~22 min windows 📦 package
✔️ 0dba438 #9 2019-01-28 13:30:15 ~24 min linux 📦 package
✔️ e348205 #10 2019-01-28 14:12:58 ~14 min macos 📦 package
✔️ e348205 #10 2019-01-28 14:14:09 ~15 min ios-e2e 📦 package
✔️ e348205 #10 2019-01-28 14:14:09 ~15 min ios 📦 package
✔️ e348205 #11 2019-01-28 14:16:53 ~18 min android 📦 package
✔️ e348205 #10 2019-01-28 14:16:58 ~18 min android-e2e 📦 package
✔️ e348205 #10 2019-01-28 14:21:17 ~22 min windows 📦 package
✔️ e348205 #10 2019-01-28 14:24:02 ~25 min linux 📦 package
✔️ cdbd4ae #11 2019-01-28 14:30:22 ~15 min ios-e2e 📦 package
✔️ cdbd4ae #11 2019-01-28 14:31:15 ~16 min ios 📦 package
✔️ cdbd4ae #11 2019-01-28 14:32:53 ~17 min macos 📦 package
✔️ cdbd4ae #12 2019-01-28 14:38:25 ~23 min android 📦 package
✔️ cdbd4ae #11 2019-01-28 14:39:54 ~24 min android-e2e 📦 package
✔️ cdbd4ae #11 2019-01-28 14:46:45 ~31 min linux 📦 package
✔️ cdbd4ae #11 2019-01-28 14:48:42 ~33 min windows 📦 package
✔️ 2f62170 #12 2019-01-28 15:10:16 ~14 min ios-e2e 📦 package
✔️ 2f62170 #12 2019-01-28 15:10:30 ~14 min ios 📦 package
✔️ 2f62170 #12 2019-01-28 15:11:28 ~15 min macos 📦 package
✔️ 2f62170 #13 2019-01-28 15:14:16 ~18 min android 📦 package
✔️ 2f62170 #12 2019-01-28 15:14:45 ~19 min android-e2e 📦 package
✔️ 2f62170 #12 2019-01-28 15:18:08 ~22 min windows 📦 package
✔️ 2f62170 #12 2019-01-28 15:20:40 ~24 min linux 📦 package
✔️ 4990da8 #13 2019-01-28 15:51:40 ~13 min macos 📦 package
✔️ 4990da8 #13 2019-01-28 15:52:24 ~14 min ios 📦 package
✔️ 4990da8 #13 2019-01-28 15:53:44 ~15 min ios-e2e 📦 package
✔️ 4990da8 #14 2019-01-28 15:55:29 ~17 min android 📦 package
✔️ 4990da8 #13 2019-01-28 15:57:11 ~19 min android-e2e 📦 package
✔️ 4990da8 #13 2019-01-28 15:57:53 ~19 min windows 📦 package
✔️ 4990da8 #13 2019-01-28 16:02:48 ~24 min linux 📦 package
✔️ 2ce7cae #14 2019-01-28 17:33:45 ~20 min ios-e2e 📦 package
✔️ 2ce7cae #14 2019-01-28 17:35:19 ~21 min ios 📦 package
✔️ 2ce7cae #14 2019-01-28 17:36:39 ~23 min android-e2e 📦 package
✔️ 2ce7cae #15 2019-01-28 17:37:09 ~23 min android 📦 package
✔️ 2ce7cae #14 2019-01-28 17:42:15 ~28 min windows 📦 package
✔️ 2ce7cae #14 2019-01-28 17:42:34 ~29 min macos 📦 package
❌ 2ce7cae #14 2019-01-28 17:42:56 ~29 min linux 📄 build log
✔️ 2ce7cae #15 2019-01-29 09:02:24 ~20 min linux 📦 package
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 40303f5 #15 2019-01-29 09:46:05 ~15 min ios-e2e 📦 package
✔️ 40303f5 #15 2019-01-29 09:46:16 ~15 min macos 📦 package
✔️ 40303f5 #15 2019-01-29 09:47:05 ~16 min ios 📦 package
✔️ 40303f5 #16 2019-01-29 09:48:13 ~17 min android 📦 package
✔️ 40303f5 #15 2019-01-29 09:50:31 ~19 min windows 📦 package
✔️ 40303f5 #16 2019-01-29 09:52:30 ~21 min linux 📦 package
✔️ 52ae2c2 #16 2019-01-29 09:54:52 ~21 min android-e2e 📦 package

@churik
Copy link
Member

churik commented Jan 24, 2019 •
edited

@cammellos so far:

1. Group chat owner (creator) is counted as 1/10 group chat members. In design, owner is not counted as 1/10 possible members. Also there is no search bar on New Group Chat screen.
hhhh

2. Create New Chat button is hidden under keyboard (IOS)
sdf

3. Can't scroll on chat name screen (Android 7.0, LG v20)

groupm

If I try to scroll with open keyboard, I can see only 6 members - others are hidden under keyboard.

4. "Cancel" button is missing on chat name screen
cancel

5. "Next" button is overlapping with checkbox on Members screen
next

6. No design changes on "Group info screen"
6.1 - no amount of chat members
6.2 - "add members" isn't under "Members"
6.3 - "Delete chat" instead "Delete and Leave"
6.4 - Admin isn't on the first place in members list
groupinfo

7. Can't add members to group chat - there is no button to proceed
Steps:

  • create groupchat
  • tap on 3 dots
  • ope Group chat info
  • tap on add member
  • select members and try to proceed

8. No changes in menus
According to designs: Overflow menu, Member overflow should be changed.
On current PR build they are the same as in nightly

@cammellos
Copy link
Member Author

@churik thanks for testing, sorry I should have mentioned which parts were implemented and which were not.

  1. Search bar will be implemented separately. For the counting, @errorists we limit the number of users to 10 (creator included), how should we show this to the user when adding/creating a group chat? 0/9 or 1/10?
    2,3,4,5,7 I will fix, while 8 and 6 I will probably leave for a separate PR.

thanks!

@churik churik moved this from IN TESTING to CONTRIBUTOR in Pipeline for QA Jan 25, 2019
@cammellos
Copy link
Member Author

@churik
1 is still pending to hear from @errorists
2) Could you check is still the case? (I have no ios device, but I can check on the simulator, but since a few things have changed it might be fixed
3) should be fixed
4) Will be in a separate pr
5) Should be fixed
6) Will be in a separate pr
7) Should be fixed
8) Will be in a separate pr

Thanks!

@errorists
Copy link
Contributor

@cammellos sorry for taking so long, tough question actually but I propose a 0/9. If we went with a 1/10 then somewhere in the UI we'd have to include the user creating a group to make it clear that he's taking one of the spots.

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_unread_messages_counter_1_1_chat
Device sessions

@churik churik moved this from TO TEST to IN TESTING in Pipeline for QA Jan 25, 2019
@churik
Copy link
Member

churik commented Jan 25, 2019 •
edited

@cammellos thanks for quick fixes!
2) is still the case unfortunately
5) is still reproducible (now last contact is fully overlapped) - video is here
On IOS and Android.
Same on Group Chat screen - button "Create group chat " overlapped last member in the list.

@churik churik moved this from IN TESTING to CONTRIBUTOR in Pipeline for QA Jan 25, 2019
@churik
Copy link
Member

churik commented Jan 28, 2019

@cammellos #7269 (comment) is fixed in the last build, so PR can be moved to To test for the final check.
thanks!

@cammellos
Copy link
Member Author

@churik awesome, I will do, thanks!

@cammellos cammellos moved this from CONTRIBUTOR to TO TEST in Pipeline for QA Jan 28, 2019
@churik churik moved this from TO TEST to IN TESTING in Pipeline for QA Jan 28, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@churik
Copy link
Member

churik commented Jan 28, 2019 •
edited

@cammellos after upgrade from 0.9.32 for all group chats created before upgrade I (as an admin) instead of group chat history see the screen where I invited myself to join group chat:
invi
Not sure that it is expected. Can you confirm please?

UPD: same behavior on nightly, but here "Decline" option is added. Is it possible to prevent displaying this screen for such cases?

@yenda
Copy link
Contributor

yenda commented Jan 28, 2019 •
edited by unfurl-links bot

If I'm not mistaken the toolbar changes are local to group chat in this PR? I was thinking of doing the toolbar revamp according to the UI components described here https://www.figma.com/file/cb4p8AxLtTF3q1L6JYDnKN15/Index?node-id=794%3A0

Figma
Created with Figma

@cammellos
Copy link
Member Author

@yenda not sure I understand, correct me if I am wrong, this changes only group-chats, not any other kind of chats, is that what you were asking?
cheers

@cammellos cammellos force-pushed the features/group-chats-styling branch 4 times, most recently from 2f62170 to 4990da8 Compare January 28, 2019 15:38
@cammellos
Copy link
Member Author

@churik it should be fixed now, I have also changed the upgrade behavior so that users won't have to join existing chats.
The behavior is as follow:

If chat has been created in nightly or 0.9.32 (anything before this PR), on upgrade to this PR they won't have to join the chat.
If chat has been created while this PR was running, the chat will have to be joined.

It does not matter who creates the chat (which version), it only matters which version of the app was running when the app was created on the device. (not sure if the explanation is clear).

thanks

@yenda
Copy link
Contributor

yenda commented Jan 28, 2019 •
edited by unfurl-links bot

@cammellos sorry for the confusion I was just curious if you were already on the implementation of top bar components, but it seems that here you just made a local update to fit the group chat design. What I am saying is that the top bar you implemented will soon be the same all accross the app according to designs here https://www.figma.com/file/cb4p8AxLtTF3q1L6JYDnKN15/Index?node-id=794%3A0

I will work on that after discussing with design team tomorrow. I doesn't matter for that PR

Figma
Created with Figma

@churik churik moved this from IN TESTING to MERGE in Pipeline for QA Jan 29, 2019
@churik
Copy link
Member

churik commented Jan 29, 2019

Note: after upgrade you will see system messages that you automatically joined to chat (if it was created on 0.9.32)
Suppose that this is expected.

Thanks @cammellos, great work here!

@cammellos
Copy link
Member Author

@churik thanks for testing!

@cammellos
Style header group-chats
52ae2c2 
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
@cammellos cammellos merged commit 52ae2c2 into develop Jan 29, 2019
Pipeline for QA automation moved this from MERGE to DONE Jan 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the features/group-chats-styling branch January 29, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@goranjovic goranjovic goranjovic approved these changes

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@yenda yenda Awaiting requested review from yenda

@rasom rasom Awaiting requested review from rasom

@errorists errorists Awaiting requested review from errorists

Assignees

@cammellos cammellos

@churik churik

Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cammellos @status-im-auto @errorists @statustestbot @churik @yenda @jeluard @goranjovic