Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command suggestions and parameters animation with native driver #8477

Merged
merged 1 commit into from Jun 26, 2019
Merged

command suggestions and parameters animation with native driver #8477

merged 1 commit into from Jun 26, 2019

Conversation

rasom
Copy link
Member

@rasom rasom commented Jun 24, 2019 •
edited

status: ready

@rasom rasom requested a review from a team as a code owner June 24, 2019 10:24
@auto-assign auto-assign bot removed the request for review from a team June 24, 2019 10:24
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 24, 2019
@status-im-auto
Copy link
Member

✔️ status-react/prs/ios/PR-8477#1 🔹 ~14 min 🔹 001acbf 🔹 📦 ios package

@status-im-auto
Copy link
Member

✔️ status-react/prs/android-e2e/PR-8477#1 🔹 ~18 min 🔹 001acbf 🔹 📦 android e2e package

@status-im-auto
Copy link
Member

✔️ status-react/prs/linux/PR-8477#1 🔹 ~18 min 🔹 001acbf 🔹 📦 linux package

@status-im-auto
Copy link
Member

✔️ status-react/prs/macos/PR-8477#1 🔹 ~18 min 🔹 001acbf 🔹 📦 macos package

@status-im-auto
Copy link
Member

✔️ status-react/prs/android/PR-8477#1 🔹 ~20 min 🔹 001acbf 🔹 📦 android package

@status-im-auto
Copy link
Member

✔️ status-react/prs/windows/PR-8477#1 🔹 ~23 min 🔹 001acbf 🔹 📦 windows package

@rasom rasom self-assigned this Jun 24, 2019
@rasom rasom force-pushed the parameters-suggestions-animation-native-driver branch from 001acbf to 516f3c6 Compare June 24, 2019 11:06
@status-im-auto
Copy link
Member

status-im-auto commented Jun 24, 2019 •
edited

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 516f3c6 #2 2019-06-24 12:39:28 ~7 min ios 📄 log
✔️ 9d50c0a #3 2019-06-24 13:00:44 ~13 min ios 📦 ipa
✔️ 9d50c0a #2 2019-06-24 13:01:40 ~14 min android-e2e 📦 apk
✔️ 9d50c0a #2 2019-06-24 13:02:43 ~15 min macos 📦 dmg
✔️ 9d50c0a #2 2019-06-24 13:04:28 ~16 min linux 📦 App
✔️ 9d50c0a #2 2019-06-24 13:07:11 ~19 min windows 📦 exe
✔️ 9d50c0a #2 2019-06-24 13:09:26 ~21 min android 📦 apk
✔️ dece8ac #4 2019-06-26 11:27:38 ~10 min ios 📦 ipa
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e3080b4 #4 2019-06-26 11:39:38 ~12 min linux 📦 App
✔️ e3080b4 #4 2019-06-26 11:41:52 ~14 min macos 📦 dmg
✔️ e3080b4 #4 2019-06-26 11:42:10 ~14 min android 📦 apk
✔️ e3080b4 #4 2019-06-26 11:42:24 ~14 min android-e2e 📦 apk
✔️ e3080b4 #5 2019-06-26 11:42:24 ~14 min ios 📦 ipa
✔️ e3080b4 #4 2019-06-26 11:48:23 ~20 min windows 📦 exe
✔️ 6c50fe8 #6 2019-06-26 14:07:39 ~11 min ios 📦 ipa
✔️ 6c50fe8 #5 2019-06-26 14:07:53 ~11 min linux 📦 App
✔️ 6c50fe8 #5 2019-06-26 14:08:07 ~11 min windows 📦 exe
✔️ 6c50fe8 #5 2019-06-26 14:09:29 ~13 min android-e2e 📦 apk
✔️ 6c50fe8 #5 2019-06-26 14:10:30 ~14 min macos 📦 dmg
✔️ 6c50fe8 #5 2019-06-26 14:11:14 ~15 min android 📦 apk

@rasom rasom force-pushed the parameters-suggestions-animation-native-driver branch from 516f3c6 to 9d50c0a Compare June 24, 2019 12:47
@rasom rasom moved this from REVIEW to E2E Tests in Pipeline for QA Jun 25, 2019
@statustestbot
Copy link

92% of end-end tests have passed

Total executed tests: 49
Failed tests: 4
Passed tests: 45

Failed tests (4)

Click to expand
1. test_public_chat_messaging

Device 2: Looking for an element by text: 'Today'
Device 2: Looking for a message by text: 'hello'

Device 2: 'Username' is not found on the screen

Device sessions

2. test_manage_assets

Device 1: Wait for AccountsMoreOptions
Device 1: Wait for AccountsMoreOptions

Device 1: 'AccountsMoreOptions' is not found on the screen

Device sessions

3. test_add_contact_from_public_chat

Device 1: Looking for a message by text: 'test message1561475770'
Device 1: Looking for message with text 'test message1561475770'

Device 1: 'Username' is not found on the screen

Device sessions

4. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for AccountsMoreOptions
Device 1: Wait for BackupRecoveryPhraseWarningText

'Back up your seed phrase' warning is not shown on Wallet

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_send_tokens_in_1_1_chat
Device sessions

28. test_network_mismatch_for_send_request_commands
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_send_eth_in_1_1_chat
Device sessions

33. test_login_with_new_account
Device sessions

34. test_send_eth_from_wallet_to_contact
Device sessions

35. test_send_two_transactions_one_after_another_in_dapp
Device sessions

36. test_password_in_logcat_creating_account
Device sessions

37. test_backup_recovery_phrase
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_request_eth_in_wallet
Device sessions

45. test_refresh_button_browsing_app_webview
Device sessions

@Serhy Serhy moved this from E2E Tests to TO TEST in Pipeline for QA Jun 25, 2019
@Serhy Serhy moved this from TO TEST to IN TESTING in Pipeline for QA Jun 25, 2019
@Serhy Serhy self-assigned this Jun 26, 2019
@Serhy
Copy link
Contributor

Serhy commented Jun 26, 2019 •
edited

@rasom, threre are regressions with current changes:

On iOS and Android:

  1. List of assets that appears for /send / /request commands is not scrollable.
  2. List of assets has different max-size: on Android whole list of assets revealed disregard top border max limit; on iOS list of assets max height seems applied but it's different that what is in develop
    (please see screenshots below for comparison with develop)

Screenshot 2019-06-26 at 13 14 17

Screenshot 2019-06-26 at 13 14 24

  1. On iOS only:
    command suggestions does not appear when tap upon [/] button or start typing message with /. If type dirrectly /send or /request in message box then assets appears but list height is different (see above items).

Screenshot 2019-06-26 at 13 06 07

@rasom rasom force-pushed the parameters-suggestions-animation-native-driver branch from 9d50c0a to dece8ac Compare June 26, 2019 11:16
@rasom
Copy link
Member Author

rasom commented Jun 26, 2019

@Serhy both issues should be fixed now

@Serhy
Copy link
Contributor

Serhy commented Jun 26, 2019

Looks good now (tested Androids 6.0.1, 8.0, 8.1 and iOS 12)
Thanks a lot, @rasom !

@Serhy Serhy moved this from IN TESTING to MERGE in Pipeline for QA Jun 26, 2019
@rasom rasom force-pushed the parameters-suggestions-animation-native-driver branch from e3080b4 to 6c50fe8 Compare June 26, 2019 13:55
@rasom rasom merged commit 6c50fe8 into develop Jun 26, 2019
Pipeline for QA automation moved this from MERGE to DONE Jun 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the parameters-suggestions-animation-native-driver branch June 26, 2019 13:56
This was referenced Jul 1, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@mandrigin mandrigin mandrigin approved these changes

@yenda yenda Awaiting requested review from yenda

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees
No one assigned
Labels
E:Mobile Performance MVP Tested - OK
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rasom @status-im-auto @statustestbot @Serhy @jeluard @mandrigin