Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign lighting logic #8

Open
stdNullPtr opened this issue May 12, 2024 · 0 comments
Open

Redesign lighting logic #8

stdNullPtr opened this issue May 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@stdNullPtr
Copy link
Owner

stdNullPtr commented May 12, 2024

Currently, for every AIR block that needs to be lit, a new BukkitRunnable is scheduled to revert it. This can introduce a significant overhead when player count arises.

Maybe we can insert all lit blocks into a queue and have a scheduler pop the last element? But each player must have a personal scheduler. This idea will be scrapped entirely in favor of lighting using packets.

Update: It turns out a lot of issues arise with the initial approach of swapping air blocks to light blocks. The lighting logic must be redesigned to use packets and properly lit a location, instead of replacing blocks with LIGHT material.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant